Reputation: 1403
I have a context that is used to show a full page spinner while my application is performing long running tasks.
When I attempt to access it inside useEffect
I get a the react-hooks/exhaustive-deps
ESLint message. For example the following code, although it works as expected, states that busyIndicator
is a missing dependency:
const busyIndicator = useContext(GlobalBusyIndicatorContext);
useEffect(() => {
busyIndicator.show('Please wait...');
}, []);
This article suggests that I could wrap the function with useCallback
which might look as follows:
const busyIndicator = useContext(GlobalBusyIndicatorContext);
const showBusyIndicator = useCallback(() => busyIndicator.show('Please wait...'), []);
useEffect(() => {
showBusyIndicator();
}, [showBusyIndicator]);
Although this works it has moved the issue to the useCallback
line which now complains about the missing dependency.
Is it ok to ignore the ESLint message in this scenario or am I missing the something?
Upvotes: 27
Views: 46931
Reputation: 361
No need to Wrap your useContext in useRef Hook. you can update your context data just call in useEffect Brackets like this.
const comingData = useContext(taskData);
useEffect(() => {
console.log("Hi useEffect");
}},[comingData]); //context data is updating here before render the component
Upvotes: 1
Reputation: 5179
If your busyIndicator
is not changed during the life of the component, you could simply add it as a dependency to useEffect
:
const busyIndicator = useContext(GlobalBusyIndicatorContext);
useEffect(() => {
busyIndicator.show('Please wait...');
}, [busyIndicator]);
If busyIndicator
could be changed and you don't want to see an error, then you could use useRef
hook:
const busyIndicator = useRef(useContext(GlobalBusyIndicatorContext));
useEffect(() => {
busyIndicator.current.show('Please wait...');
}, []);
The useRef() Hook isn’t just for DOM refs. The “ref” object is a generic container whose current property is mutable and can hold any value, similar to an instance property on a class. read more
Upvotes: 49