sluther
sluther

Reputation: 1724

Why am I getting this error with socket_read()?

I have the following code: http://pastebin.com/U9qYSmET

When I try to telnet into my server and port with

telnet localhost 6667

I get the following error:

PHP Warning: socket_read(): unable to read from socket [107]: Transport endpoint is not connected in /var/www/php-irc/proxy.php on line 91

Anyone have any ideas why I'm getting this error?

Code:

<?php 

if(!defined('SOCKET_ADDRESS')) {
    define('SOCKET_ADDRESS', '127.0.0.1');
}

if(!defined('SOCKET_PORT')) {
    define('SOCKET_PORT', '6667');
}

if(!defined('MAX_CLIENTS')) {
    define('MAX_CLIENTS', '10');
}
set_time_limit(0);

$socket = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
socket_set_option($socket, SOL_SOCKET, SO_REUSEADDR, 1);
socket_bind($socket, SOCKET_ADDRESS, SOCKET_PORT) or die('Could not bind to address ' . SOCKET_ADDRESS . ' on port ' . SOCKET_PORT . "!\n");
socket_listen($socket, MAX_CLIENTS) or die ("Could not setup socket listener!\n");

// setup read socket array
$read = array();

// client array w/ default initial socket
$clients = array('0' => array('socket' => $socket));

// force debug at first run..
$debug = true;
$time = time();
printf('Time: %d%s', $time, "\n");
while(true) {

    if(time() - $time >= 10) {
        $time = time();
        printf('Time: %d%s', $time, "\n");
        $debug = true;
    }
    if($debug === true) {
        printf('Debug: %s%s', $debug, "\n");
    }
    // $read[0] = $socket;
    if($debug) {
        var_dump($read);
    }

    // Handle clients
    for($i = 0; $i < count($clients); $i++) {
        if(isset($clients[$i]['socket'])) {
            if($debug === true) {
                printf('Setting socket %d to client %d%s', $i, $i, "\n");
            }
            $read[$i] = $clients[$i]['socket'];
        }
    }
    if($debug) {
        var_dump($read);
    }
    // Any changed sockets?
    // $write and $except are only placeholders
    $changed_sockets = socket_select($read, $write = NULL, $except = NULL, 0);
    if($debug === true){
        printf('Changed sockets: %d%s', $changed_sockets, "\n");
    }
    // Handle new connections
    if(in_array($socket, $read)) {
        for($i = 0; $i < MAX_CLIENTS; $i++) {
            if(!isset($clients[$i])) {
                $clients[$i]['socket'] = socket_accept($socket);
                socket_getpeername($clients[$i]['socket'],$ip);
                $clients[$i]['ip'] = $ip;
                printf('Accepting connection into client %d from %s%s', $i, $ip, "\n");
                break;
            }
            // } elseif($i == MAX_CLIENTS - 1) {
                // echo 'Too many clients connected!', "\n";
            // }
            if($changed_sockets < 1) {
                continue;                
            }
        }
    }
    if($debug) {
        var_dump($clients);
    }

    for($i = 0; $i < count($clients); $i++) {
        $client = $clients[$i];
        // Has our client socket seen any changes?
        if(in_array($client['socket'], $read)) {
            printf('Client %d has changed! Reading...%s', $i, "\n");
            $data = socket_read($client['socket'], 1024);
            if($data === false) {
                $error = socket_strerror(socket_last_error());
                printf('An error occured...%s%s', $error, "\n");

            }
            printf("Read raw data %s from client %i%s", $data, $i, "\n");
            if($data === null) {
                // disconnected
                unset($clients[$i]);
            }

            $data = trim($data);
            if($data == 'exit') {
                printf('Received exit command from client%s', "\n");
                socket_close($clients[$i]['socket']);
            } elseif($data) {
                // Strip whitespace
                printf('Received data: %s from client %d%s', $data, $i, "\n");
                $output = sprintf('%s%s%s', $data, "\n", chr(0));
                socket_write($client['socket'], $output);
            }
        }
    }

    // reset debug
    $debug = false;
}

socket_close($socket);

Upvotes: 0

Views: 5992

Answers (2)

sluther
sluther

Reputation: 1724

The problem was it was trying to read from $clients[0]. Which isn't a valid client to be reading from. I simply changed the last two for loops to start $i at 1.

So far in my testing, this doesn't seem to be having any adverse affects. The error is gone, and I all of the client instances appear to be working fine.

Upvotes: 0

k to the z
k to the z

Reputation: 3185

You haven't connected to anything yet. you need:

socket_connect($socket, $address, $service_port);

in an if statement to see if you can connect.

Upvotes: 1

Related Questions