CODEWITHSUNDEEP
c#unity-game-engine
Eloren
Eloren

Reputation: 323

One line stops script C# Unity

Some part of the code works (hp1 -= damage1;), but the second part doesn't work. Where did I make a mistake?

Here are parts of two scripts:

Player1.cs

private Bullet1 b1;

void Start()
{
    b1 = FindObjectOfType<Bullet1>();
}

void OnCollisionEnter2D(Collision2D col)
{
    if (col.gameObject.tag == "Bullet1")
    {
        hp1 -= damage1; // it works, my player loses hp
        Destroy1(); // doesn't work
    }
}

void Destroy1()
{
    b1.hit1 = true; // hit for bullet1.cs
}

Bullet1.cs

public bool hit1;

void Update()
{
    if (hit1)
    {
        hit1 = false;
        Destroy(gameObject);
    }
}

If I switch bool hit = true in real time in Unity, destroying works. It means that Bullet1.cs can't recieve hit = true;

If I swap lines hp1 -= damage1; and Destroy1();, my player can't get damage. So, Destroy1(); stops my code and then can't activate other lines. Also if I change Destroy1(); to b1.hit1 = true; nothing new happens.

Upvotes: 1

Views: 80

Answers (1)

Tim Hunter
Tim Hunter

Reputation: 242

Just destroy the bullet through the collision instead of using the boolean. It's creating unnecessary resource usage. Of the given code, this is all you need to do to destroy the bullet using the player script. The parts of the bullet script shown are unnecessary. If you want additional logic handled inside the bullet when destroyed then use a OnDestroy function to handle it.

void OnCollisionEnter2D(Collision2D col)
{
    if (col.gameObject.tag == "Bullet1")
    {
        hp1 -= damage1;
        Destroy(col.gameobject); 
    }
}

Upvotes: 2

Related Questions