CODEWITHSUNDEEP
phpmysql
john
john

Reputation: 1330

INSERT INTO not writing into database?

i'm trying to write info into a db table and it's not working at all. i've been messing with it for hours. maybe if someone looks at the code they'll see something i missed.

my logic is it connects to the db server, opens database mydb, goes to table mod, and writes to id, fname, and lname, then closes the connection.

also, id is set to auto_increment. from what i can tell it should work but it doesn't.

$con = mysql_connect("localhost","user","pass");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db('mydb', $con);

//assign
$query = "INSERT INTO 'mod' (id, fname, lname) VALUES ('', 'bill', 'smith')";
if (!$query){ 
dir ("Unable to create the record:" . mysql_error()); 
exit; 
}
mysql_query($query);
mysql_close($con);

Upvotes: 1

Views: 147

Answers (5)

k to the z
k to the z

Reputation: 3185

Change your query to:

$query = "INSERT INTO mod (fname, lname) VALUES ('bill', 'smith')";

Your auto increment id will be added by the database automatically.

UPDATE

Your error code should look like this to work:

$query = "INSERT INTO mod (fname, lname) VALUES ('bill', 'smith')";
$result = mysql_query($query);
if (!$result) {
    die('Invalid query: ' . mysql_error());
}

Upvotes: 1

KoolKabin
KoolKabin

Reputation: 17653

you are making miskate in referencing the tablename. It should be `mod` instead of 'mod'. i.e ` [backtick] not '[single quote].

and second error is with your die statement...instead of dir it should be die....

INSERT INTO `mod` (id, fname, lname) VALUES ('', 'bill', 'smith');

Next you can also skip inserting value for id field which is autoincreament

so it can be

INSERT INTO `mod` (fname, lname) VALUES ('bill', 'smith');

Upvotes: 0

Jon
Jon

Reputation: 12992

You could also try:

$query = "INSERT INTO mod SET fname='bill', lname='smith'";

And the id column would autoincrement magically.

Upvotes: 0

rATRIJS
rATRIJS

Reputation: 309

You actually have to call mysql_query to execute query (to see the mysql_error).

Upvotes: 0

gnur
gnur

Reputation: 4733

There should be no quotes around 'mod'

//edit:
Also, the if (!query) part isn't really useful at that moment because it is checking the string, not the result. You should check the result of mysql_query() and if that failed you should output an error message.

Upvotes: 1

Related Questions