CODEWITHSUNDEEP
javaseleniumselenium-webdriverweb-scrapingselenium-chromedriver
Alex Mi
Alex Mi

Reputation: 1459

selenium webdriver does not find the correct number of elements

Initially, I posted my question here:

Extracting content from a dynamic web site using a Java Library

Then, after reading and applying the info from the question below:

Selenium Webdriver : not displaying the correct Li elements

I installed a selenium chrome driver (Version ChromeDriver 74.0.3729.6), my chrome browser has version 74.0.3729.169. The selenium WebDriver java object is still unable to correctly find the number of elements on my web-page, altough I simulated a scroll-down and the chrome browser that the driver opened did correctly show the total number of 20 elments.

    import java.util.List;

    import org.openqa.selenium.By;
    import org.openqa.selenium.WebDriver;
    import org.openqa.selenium.WebElement;
    import org.openqa.selenium.chrome.ChromeDriver;
    import org.openqa.selenium.support.ui.ExpectedConditions;
    import org.openqa.selenium.support.ui.WebDriverWait;

     public class ImmoweltBot {

    public static final String URL2 = "https://www.immowelt.at/liste/wien-2-leopoldstadt/wohnungen/mieten?sort=price&cp=2";


    public static void main(String[] args) throws Exception {
        System.setProperty("webdriver.chrome.driver", "C:\\Temp\\chromedriver.exe");

        WebDriver webDriver = new ChromeDriver();
        webDriver.get(URL2);
        WebDriverWait wait = new WebDriverWait(webDriver, 15);
        By searchResults = By.xpath("//*[contains(@class, 'listitem clear relative js-listitem')]");

        JavascriptExecutor js = (JavascriptExecutor)webDriver;
        webDriver.manage().window().maximize();
        js.executeScript("window.scrollBy(0,1000)");

        wait.until(ExpectedConditions.numberOfElementsToBeMoreThan(searchResults, 4));
        List<WebElement> elemnts = webDriver.findElements(searchResults);
        System.out.println(elemnts.size());
    }

}

My web-page:

https://www.immowelt.at/liste/wien-2-leopoldstadt/wohnungen/mieten?sort=price&cp=2

Any help will be appreciated. Thank you!

Upvotes: 0

Views: 757

Answers (2)

Gennady Zyablitsev
Gennady Zyablitsev

Reputation: 185

Thanks for this question, it was so challenging. So Here is my solution. This is js to smooth scroll until down. 

(async function() {
function sleep() {
    return new Promise(resolve => setTimeout(resolve, 500))
};
var height;
do {
    height = document.body.scrollHeight;
    window.scrollTo({
        "behavior": "smooth",
        "left": 0,
        "top": document.body.scrollHeight
    });
    await sleep()
} while (height != document.body.scrollHeight)})();

I used async function because chomedriver.executeScript() wants async function to use 'await' statement. 

String scrollWhileScrollsJS = "(async function(){function sleep(){return new Promise(resolve=>setTimeout(resolve,500))};var height;do{height=document.body.scrollHeight;window.scrollTo({\"behavior\":\"smooth\",\"left\":0,\"top\":document.body.scrollHeight});await sleep()}while(height!=document.body.scrollHeight)})();";
( (ChromeDriver) webDriver ).executeScript( scrollWhileScrollsJS );

And of course we need fluent wait. For this, i found that 'scrollY' will be equals to 'document.body.scrollHeight-innerHeight' only while we on the bottom of the page. 

new FluentWait<>( webDriver ).withTimeout( Duration.ofSeconds( 10 ) )
                             .pollingEvery( Duration.ofMillis( 500 ) )
                             .until( result -> ( (ChromeDriver) webDriver ).executeScript( "return scrollY" ).equals( ( (ChromeDriver) webDriver ).executeScript( "return document.body.scrollHeight-innerHeight" ) ) );

As a result, you can use this code to scroll the page, wait for it is scrolled to the end and get elements without knowledge of how many it should be.

PS: please, do not... i mean, really, DO NOT use while(true) in your automation tests.

Upvotes: 1

KunduK
KunduK

Reputation: 33384

It is a bit tricky.You have to use infinite loop to check the elements size() and scroll down to page once it reach 20 it will jumps out of the loop.

WebDriver driver = new ChromeDriver();
driver.get("https://www.immowelt.at/liste/wien-2-leopoldstadt/wohnungen/mieten?sort=price&cp=2");
WebDriverWait wait = new WebDriverWait(driver, 15);

while(true){

  List<WebElement> elemnts=wait.until(ExpectedConditions.presenceOfAllElementsLocatedBy(By.xpath("//div[contains(@class, 'listitem clear relative js-listitem')]")));                               

   driver.findElement(By.tagName("body")).sendKeys(Keys.DOWN);

   if (elemnts.size()==20)
       {
          System.out.println(elemnts.size());   
          break;
       }               

        }

Upvotes: 1

Related Questions