CODEWITHSUNDEEP
c++winsock
73areo
73areo

Reputation: 25

Winsock 400 Bad Request, openresty

So I have a authentication system for my software where I send a GET request to my server that validates it which then echos back true or false. When ever I use Winsock to send the HTTP request I get an error: 400 bad request and below it is openresty. Any help appreciated!

#define _WIN32_WINNT 0x0400

#include <iostream>
#include <locale>
#include <sstream>
#include <vector>
#include <stdio.h>
#include <string.h>
#include <windows.h>
#include <winsock2.h>
#pragma comment(lib, "ws2_32.lib")

using namespace std;

void main() {
    WSADATA wsaData;
    SOCKET Socket;
    SOCKADDR_IN SockAddr;
    int lineCount = 0;
    int rowCount = 0;
    struct hostent* host;
    locale local;
    char buffer[10000];
    int i = 0;
    int nDataLength;
    string website_HTML;

    // website url
    string url = "www.mysitewebsite.com/auth/auth.php?hwid=" + hwidPro +
                 "&username=" + Username + "&password=" + Password;

    // HTTP GET
    string get_http =
        "GET / HTTP/1.1\r\nHost: " + url + "\r\nConnection: close\r\n\r\n";

    if(WSAStartup(MAKEWORD(2, 2), &wsaData) != 0) {
        cout << "WSAStartup failed.\n";
        system("pause");
        // return 1;
    }

    Socket = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
    host = gethostbyname("www.mysite.com");

    SockAddr.sin_port = htons(80);
    SockAddr.sin_family = AF_INET;
    SockAddr.sin_addr.s_addr = *((unsigned long*)host->h_addr);

    if(connect(Socket, (SOCKADDR*)(&SockAddr), sizeof(SockAddr)) != 0) {
        cout << "Could not connect";
        system("pause");
        // return 1;
    }

    // send GET / HTTP
    send(Socket, get_http.c_str(), strlen(get_http.c_str()), 0);

    // recieve html
    while((nDataLength = recv(Socket, buffer, 10000, 0)) > 0) {
        int i = 0;
        while(buffer[i] >= 32 || buffer[i] == '\n' || buffer[i] == '\r') {
            website_HTML += buffer[i];
            i += 1;
        }
    }

    closesocket(Socket);
    WSACleanup();

    const char* result = website_HTML.c_str();
    Log::Msg(result);
    if(website_HTML == "true") {
        authsucsess();

    } else {
        Log::Fatal(result);
        Log::Fatal("Invalid Login or HWID");
        exit(0);
    }
}

I have edited my post the be a minimal, reproducible example. Hope its better Edit 2: I have added the HTTP response:

HTTP/1.1 400 Bad Request 
Date: Sat, 22 Jun 2019 21:33:11 GMT
Content-type: text/html
content-length: 170
connection: close
Server: awex
X-Xss Protection: 1; mode=block 
X-Content-Type-Options: nosniff
X-Request-ID: 7ccdf09347f06d7a061ad41aa45d5af7

<html>
<head><title>400 Bad Request</title></head>
<body bgcolor="white">
<center><h1>400 Bad Request</h1></center>
<hr><center>openresty</center>
</body>
</html>

Upvotes: 1

Views: 2452

Answers (1)

Remy Lebeau
Remy Lebeau

Reputation: 596156

Your GET request is malformed. This is what you are sending:

GET / HTTP/1.1
Host: www.mysitewebsite.com/auth/auth.php?hwid=[...]&username=[...]&password=[...] 
Connection: close

It needs to look like this instead:

GET /auth/auth.php?hwid=[...]&username=[...]&password=[...] HTTP/1.1
Host: www.mysitewebsite.com
Connection: close

Try this:

string s_host = "www.mysitewebsite.com";
string s_resource = "/auth/auth.php";
string s_query = "?hwid=" + hwidPro + "&username=" + Username + "&password=" + Password;

string url = s_host + s_resource + s_query;

string get_http = "GET " + s_resource + s_query + " HTTP/1.1\r\n"
    "Host: " + s_host + "\r\n"
    "Connection: close\r\n"
    "\r\n";

...

host = gethostbyname(s_host.c_str());

...

send(Socket, get_http.c_str(), get_http.size(), 0);

...

while((nDataLength = recv(Socket, buffer, sizeof(buffer), 0)) > 0)
{
    website_HTML.append(buffer, nDataLength);
}

...

Upvotes: 3

Related Questions