CODEWITHSUNDEEP
springconstructorsetterautowired
user689842
user689842

Reputation:

Spring autowiring setter/constructor PROs and CONs

When using @Autowired (not xml configuration), could someone compare the set/constructor binding advantages and disadvantages?

See the following examples:

public class Example{
   private Logger log;
   // constructor wiring
   @Autowired 
   public Example(Logger log){
      this.log = log;
   }
}

public class Example{
   // setter wiring
   @Autowired 
   private Logger log;
}

Upvotes: 16

Views: 5073

Answers (4)

Akash5288
Akash5288

Reputation: 1945

If you weren't using autowiring, there is a big difference between constructor and setter injection. You write the XML differently in order to inject the dependencies. And setter injection dependencies are optional while constructor injection dependencies are not.

With autowiring, the only reason I can think of is to avoid a circular dependency problem. If A has B has an autowired dependency to the constructor and B has the same for A, we can't instantiate either of them. Giving one a setter dependency could help with that.

Upvotes: 0

Lolo
Lolo

Reputation: 4159

Playing the devil advocate long after everyone voted for field injection, here are some advantages for using constructors gathered from polling coworkers around:

  • allows to use final and enforce immutability
  • it is a little less likely to forget to annotate an injected property in the constructor than as a field
  • makes it harder for someone to casually construct an object that should be constructed via the injector

I still like the fact that if I need an annotated field in another class, I can just do a copy-paste and be done with it as opposed to adding it to the constructor, but it is only a secondary consideration.

Upvotes: 7

wm schauweker
wm schauweker

Reputation: 21

A specific reason for annotating setters: The setters can then save bean references to static variables.

Upvotes: 2

Bozho
Bozho

Reputation: 597096

It is entirely a matter of preference.

Spring frowns upon constructor injection, or at least used to, because thus circular dependencies appear and they are hard to manage (A needs B in constructor, B needs A in constructor).

One actual difference is that with @Autowired on a field you don't need a setter method, which, on one hand makes the class smaller and easier to read, but on the other hand makes mocking the class a bit uglier.

I prefer the field injection.

Upvotes: 14

Related Questions