CODEWITHSUNDEEP
multithreadingcouchbasesql++spring-data-couchbase
Lho Ben
Lho Ben

Reputation: 2149

Spring data Couchbase generated query method not thread safe

When i extend CouchbaseRepository interface in order to do a findByField exp findByProvider --> the method generated is not thread safe :

My interface :

public interface WarehouseRepository extends CouchbaseRepository<WarehouseEntity, String> {

    List<WarehouseEntity> findByProvider(String provider);

}

I created a pool of thread in order to test it :

int threads = 3;
ExecutorService service = Executors.newFixedThreadPool(threads);
Collection<Future<Boolean>> futures = new ArrayList<>(threads);
for (int thread = 0; thread < threads; ++thread) {
    String provider ="P1";
    if(thread == 0)
        provider =  "P1";
    if (thread == 1)
        provider =  "P2";
    if(thread == 2)
        provider =  "P3";
    String expectedProvider = provider;
    Callable<Boolean> booleanSupplier = () -> {
        String foundProvider = warehouseService.findByProvider(expectedProvider).get(0).getProvider().toString();
        System.out.println("expectedProvider = " + expectedProvider  + " foundProvider = " + foundProvider);
        return expectedProvider.equals(foundProvider);//should never get false
    };

    futures.add(service.submit(booleanSupplier));
}
Set<Boolean> foundProviders = new HashSet<>();
for (Future<Boolean> future: futures) {
    foundProviders.add(future.get());
}
if (1 != foundProviders.size()) {
    System.out.println("got bad provider response for my query");
}

Here is a result of one of my executions :

2019/07/03 13:30:39.056 DEBUG Executing N1QL query: {\"args\":[\"P1\"],\"statement\":\"SELECT META(`oms`).id AS _ID, META(`oms`).cas AS _CAS, `oms`.* FROM `oms` WHERE (`provider` = $1) AND `_class` = \\"com.cmt.WarehouseEntity\\"\",\"scan_consistency\":\"statement_plus\"}
2019/07/03 13:30:39.058 DEBUG Executing N1QL query: {\"args\":[\"P3\"],\"statement\":\"SELECT META(`oms`).id AS _ID, META(`oms`).cas AS _CAS, `oms`.* FROM `oms` WHERE (`provider` = $1) AND `_class` = \\"com.cmt.WarehouseEntity\\"\",\"scan_consistency\":\"statement_plus\"}
2019/07/03 13:30:39.056 DEBUG Executing N1QL query: {\"args\":[\"P1\"],\"statement\":\"SELECT META(`oms`).id AS _ID, META(`oms`).cas AS _CAS, `oms`.* FROM `oms` WHERE (`provider` = $1) AND `_class` = \\"com.cmt.WarehouseEntity\\"\",\"scan_consistency\":\"statement_plus\"}
expectedProvider = P2 foundProvider = P1
expectedProvider = P3 foundProvider = P3
expectedProvider = P1 foundProvider = P1
got bad provider for my query

For the query in the first line expectedProvider = P2 foundProvider = P1 we get result of warehousee p1 for a query to find warehouse p2

But when i add @Query to my method, it becomes by magic thread safe .

@Query("#{#n1ql.selectEntity} WHERE #{#n1ql.filter} AND $1 = provider")
List<WarehouseEntity> findByProvider(String provider);

How it is possible ?

Thanks

Upvotes: 4

Views: 325

Answers (1)

Marcin Cichocki
Marcin Cichocki

Reputation: 36

this issue seems to have been introduced by this change in November 2018.

Downgrade your spring-data-couchbase to 3.1.2.RELEASE.

Upvotes: 2

Related Questions