CODEWITHSUNDEEP
google-cloud-platformgoogle-cloud-functionsgoogle-cloud-spanner
T.Kiril
T.Kiril

Reputation: 61

Session leak on spanner insert from cloud function

I'm trying to insert data into spanner through cloud function, using post request. I thing that I'm doing everything as described in the documentation, and i just can't understand what causes the next error:

"Error: 1 session leak(s) detected. at _requests.onIdle.then (/srv/node_modules/@google-cloud/spanner/build/src/session-pool.js:193:25) at <anonymous>"

And there is my cloud function

const {Spanner} = require('@google-cloud/spanner');

module.exports.http = (req, res) => {
  const projectId = 'project-id';
  const instanceId = 'instance-id';
  const databaseId = 'database-id';

  const spanner = new Spanner({
    projectId: projectId,
  });

  const instance = spanner.instance(instanceId);
  const database = instance.database(databaseId);

  let sqlResponse = "";

  database.runTransaction(async (err, transaction) => {
    if (err) {
      res.status(500).send(JSON.stringify({message: err, requestBody: req.body}));
      return;
    }
    try {
      const data = req.body;
      const [rowCount] = await transaction.runUpdate({
        sql:
          'INSERT Feedbacks (age, comment, gender, rating) VALUES (@age, @comment, @gender, @rating)', 
        params: {
          age: data.age.toString(),
          comment: data.comment,
          gender: data.gender,
          rating: data.rating.toString(),
        },
      });
      sqlResponse = 'Successfully inserted ' + rowCount + ' record into the Feedbacks table.';
      await transaction.commit();
      res.status(200).send(JSON.stringify({message: sqlResponse, requestBody: req.body}));
    } catch (err) {
      res.status(500).send(JSON.stringify({message: err, requestBody: req.body}));
    } finally {
      database.close();
    }
  });

};

Upvotes: 0

Views: 1188

Answers (1)

JonathanSimon
JonathanSimon

Reputation: 346

Your code appears to be correct. As noted by @Mayeru in the comments for your question, the first thing to confirm is that you're inserting a new record with a unique value specified for the column that is your table's primary key column.

Another possibility that could be causing the issue you are encountering is that you are trying to test the function using the "Testing" UI of the Cloud Console's Cloud Functions > "Function details" section. If so then you may be either using an empty request body or a malformed request body when you click the "Test the function" button. In the "Triggering event" textarea that appears above the "Test the function" button, make sure you have entered a valid JSON request body which includes the elements and values that your INSERT statement expects.

For example a "Triggering event" JSON request body like the following should work:

{"singerId":"1001","firstName":"Test","lastName":"Singer"}

Using the following "nodeInsert" function that's similar to the code you've shared:

const {Spanner} = require('@google-cloud/spanner');

module.exports.nodeInsert = (req, res) => {

  const projectId = 'my-project';
  const instanceId = 'my-instance';
  const databaseId = 'my-database';

  const spanner = new Spanner({
    projectId: projectId,
  });

  const instance = spanner.instance(instanceId);
  const database = instance.database(databaseId);

  let sqlResponse = "";

  database.runTransaction(async (err, transaction) => {
    if (err) {
      res
        .status(500)
        .send(JSON.stringify({message: err, requestBody: req.body}));
      transaction.end();
      console.error('Transaction terminated.');
      return;
    }
    try {
      const data = req.body;
      const parsedSingerId = parseInt(data.singerId, 10);
      const [rowCount] = await transaction.runUpdate({
        sql:
          'INSERT Singers (SingerId, FirstName, LastName) VALUES (@singerId, @firstName, @lastName)', 
        params: {
          singerId: parsedSingerId,
          firstName: data.firstName,
          lastName: data.lastName,
        },
      });
      sqlResponse = 'Successfully inserted ' + rowCount + ' record into the Singers table.';
      await transaction.commit();
      res
        .status(200)
        .send(JSON.stringify({message: sqlResponse, requestBody: req.body}));
    } catch (err) {
      res
        .status(500)
        .send(JSON.stringify({message: err, requestBody: req.body}));
      transaction.end();
      console.error('Transaction terminated.');
    } finally {
      database.close();
    }
  });
};

Upvotes: 2

Related Questions