CODEWITHSUNDEEP
iosswiftuitableview
Tejas Sharma
Tejas Sharma

Reputation: 472

If a UITableViewController captures self in a performBatchUpdates completion handler, can that cause a retain cycle?

Say I have a UITableViewController subclass which has some function in it, eg:

class MyTableVC: UITableViewController {
    func doSomething() { ... }
}

and I add a function to it that calls performBatchUpdates with a completion handler which captures self:

    func updateStuff() {
        tableView.performBatchUpdates(someUpdates, completion: { _ in 
            self.doSomething()
        }
    }

Is there a danger of creating a retain cycle? If so, is the view controller guaranteed to be non-nil in the callback? i.e. If there's a possibility of a retain cycle, can I use [unowned self] or is it necessary to use [weak self]

Upvotes: 2

Views: 332

Answers (1)

Denis
Denis

Reputation: 3353

There is no major issue in your solution. self will only be retained until the completion of batch update which is fine. And I'd probably do the same not to complicate the code.

Regularly it is a bit better to still have weak or unowned just to maintain similar code style through your project.

If you decide to pick one of these, weak is the only safe option here. For example, the view controller can be removed from the screen and deallocated while the table performs the update operation (the chance is really tiny but still exists) which will cause a crash in the result.

Upvotes: 3

Related Questions