CODEWITHSUNDEEP
androidkotlinmvvmandroid-databinding
Sandip Armal Patil
Sandip Armal Patil

Reputation: 5905

onClick not working in mvvm in Android databinding

I am trying to implement mvvm and databinding in Kotlin for the first time. I followed some tutorial and able to implement same. But now button click is not working which I have written in mvvm.

Here is activity_login.xml

<?xml version="1.0" encoding="utf-8"?>
<layout xmlns:app="http://schemas.android.com/apk/res-auto">
<data>
    <variable
            name="viewmodel"
            type="com.abc.abc.presentation.user.viewmodels.LoginViewModel"/>
</data>
<RelativeLayout
        xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:tools="http://schemas.android.com/tools"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        tools:context=".presentation.user.views.LoginActivity"
        android:layout_margin="24dip">
    <Button
            android:layout_width="match_parent"
            android:layout_height="40dip"
            android:background="@drawable/btn_user_create_account"
            android:layout_above="@+id/or_layout"
            android:layout_marginBottom="24dp"
            android:text="@string/create_account"
            android:id="@+id/btn_create_account"
            android:layout_marginEnd="12dip"
            android:layout_marginStart="12dip"
            android:gravity="center_horizontal|center_vertical"
            android:textColor="@color/text_color"
            android:textAllCaps="false"
            android:onClick="@{() -> viewmodel.redirectToRegisterActivity()}"
            android:fontFamily="@font/vollkron"
            android:textStyle="bold"
    />
    <Button
            android:layout_width="match_parent"
            android:layout_height="40dip"
            android:background="@drawable/btn_user_login_reg"
            android:layout_above="@+id/btn_create_account"
            android:layout_marginBottom="12dp"
            android:text="@string/login"
            android:id="@+id/btn_login"
            android:layout_marginEnd="12dip"
            android:layout_marginStart="12dip"
            android:gravity="center_horizontal|center_vertical"
            android:textColor="@color/white"
            android:textAllCaps="false"
            android:onClick="@{() -> viewmodel.executeEmailLogin(context)}"
            android:fontFamily="@font/vollkron"
            android:textStyle="bold"/>
 </RelativeLayout>

Here is my ViewModel code :

class LoginViewModel(application: Application) : AndroidViewModel(application) {


var email: ObservableField<String>? = null
var password: ObservableField<String>? = null
var progressDialog: SingleLiveEvent<Boolean>? = null
var launchRegisterActivity: SingleLiveEvent<Boolean>? = null
var userLogin: LiveData<User>? = null

init {
    progressDialog = SingleLiveEvent<Boolean>()
    launchRegisterActivity = SingleLiveEvent<Boolean>()
    email = ObservableField("")
    password = ObservableField("")
    userLogin = MutableLiveData()
}

fun redirectToRegisterActivity() {
    launchRegisterActivity?.value = true
}

fun executeEmailLogin(context: Context)  {
    progressDialog?.value = true
    val user = User(
        email = email.toString(),
        password = password.toString(),
        )

    userLogin = UserRepository.getInstance().registerUserUsingEmail(context, user)

}

}

Here is my Login Activity

class LoginActivity : AppCompatActivity() {

var binding: ActivityLoginBinding? = null
var viewModel: LoginViewModel? = null
var customProgressDialog: CustomProgressDialog? = null


override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    FacebookSdk.sdkInitialize(applicationContext);

    binding = DataBindingUtil.setContentView(this, R.layout.activity_login)
    customProgressDialog = CustomProgressDialog(this)
    viewModel = ViewModelProviders.of(this).get(LoginViewModel::class.java)
    observeViewModel(viewModel!!)
}

private fun observeViewModel(viewModel: LoginViewModel) {
    viewModel.progressDialog?.observe(this, Observer {
        if (it!!) customProgressDialog?.show() else customProgressDialog?.dismiss()
    })

    viewModel.launchRegisterActivity?.observe(this, Observer {
        if (it!!) startActivity(Intent(this, RegisterActivity::class.java))
    })

    viewModel.userLogin?.observe(this, Observer { user ->
        // redirect user to home scree
        Toast.makeText(this, "welcome, ${user?.user_name}", Toast.LENGTH_LONG).show()
    })

}
}

What things am I doing wrong here? Have I implemented mvvm correctly? Any button click is not working.

Upvotes: 3

Views: 7628

Answers (3)

faribakhandani
faribakhandani

Reputation: 49

Try to add :

   loginBinding =DataBindingUtil.inflate(inflater, R.layout.fragment_login,container,false)

        viewModelLogin = ViewModelProvider(this, factory).get(ViewModelLogin::class.java)
        loginBinding.mvvmlogin =viewModelLogin

 return loginBinding.root

Upvotes: 0

Ehsan Aminifar
Ehsan Aminifar

Reputation: 525

I think, You forgot to bind viewmodel to databinding. Add this in onCreate of LoginActivity :

binding.lifecycleOwner = this
binding.viewmodel = viewModel

Upvotes: 18

Francesc
Francesc

Reputation: 29260

Try adding

binding.lifecycleOwner = this

after inflating your layout.

Upvotes: 4

Related Questions