CODEWITHSUNDEEP
javaif-statementwhile-loop
Fishy_Code
Fishy_Code

Reputation: 61

Euclid's algorithm shows wrong conclusion

Homework of mine is to create and Euclid's algorithm in java. The task binds me to use both while-loop and if statement. Futhermore - if statement has to be placed inside while-loop.

During this task i faced already infinity-loop problem, somehow manage to get pass it. Now my Euclid's algorithm is giving multiple answers (instead of one) and futhermore they are wrong...

I have searched a couple of topics over here, but none of answers shown in there gave me an answer. I tried to rewrite whole code, and also diffrent conditions for while-loop and if statement. 

import java.lang.*;

class EuklidesAlgorithm {
    public static void main (String[] args) throws java.lang.Exception{
        int a = 25648;
        int b = 15468;

        while (a % b != 0 ){
            int modulo = a % b;
            if (modulo == 0){
                break;
            }else {
                modulo = a % b;
                System.out.println(" Checking for GCD");
                a = b;
                b = modulo;
            }
            System.out.println(" Number " + b + " is GDC of numbers(" + a + "," + b + ").");
        }
    }
}

I would like it to give a single answer what is GCD for a and b.

Upvotes: 0

Views: 64

Answers (1)

YourHelper
YourHelper

Reputation: 735

First of all the condition :

modulo==0

will alaways be false inside the loop... and you dont have to change variable prices inside the loop and you also don't have to print answers in every loop so... the if statement is probably goind to be used to check if any of those two numbers is 0 or if the result is 0 but you can do both

Upvotes: 1

Related Questions