CODEWITHSUNDEEP
javamultithreading
InfernalRapture
InfernalRapture

Reputation: 591

Java Thread not cleaning up

I'm currently attempting to write a Logger style thread. I'm not using the existing API because this is partially an exercise to improve my threading.

When the thread is interrupted, I need it to shutdown gracefully, flushing the last of it's queued messages and closing the file streams.

Currently, it shuts down but messages are often still in queue, and I'm concerned that the file streams aren't being closed gracefully.

This is my run()

while(!shutdown){
    writeMessages();
    try{
        Thread.sleep(5000);
    } 
    catch (InterruptedException e) {
    }
}try {
    writeMessages();
} catch (CustomException e1) {
    e1.printStackTrace();
}
try {
    logFile.close();
} catch (IOException e) {
    e.printStackTrace();
}
try {
    errFile.close();
} catch (IOException e) {
    e.printStackTrace();
}

Upvotes: 0

Views: 4478

Answers (3)

Denis Bazhenov
Denis Bazhenov

Reputation: 9945

Java has very neat way to shutdown threads. It's called interruption flag. When you want to interrupt thread you simply write following code:

thread.interrupt();
thread.join();

And in the Runnable of background thread you should check interruption flag and behave accordingly. If you want thread to survive until messages are left you can do it in a following manner (I assume you have some way of checking is there any messages left. In my case it's a BlockingQueue):

Thread self = Thread.currentThread();
BlockingQueue<String> messages = ...;

while (!self.isInterrupted() || !messages.isEmpty()) {
  try {
    String message = messages.take();
    writeMessage(message);
  } catch (InterruptedException) {
    self.interrupt();
  }
}

One more thing. You should ensure that messages are not added to the queue after thread shutdown is requested or shutdown all threads generating messages before writing thread. This also could be done checking thread interruption flag (you need to know reference to a writer thread):

public void addMessage(String message) {
  if (thread.isInterrupted() || !thread.isAlive()) {
    throw new IllegalStateException();
  }
  messages.add(message);
}

Also I recommends you to see at java.util.concurrent package. It have a lot of useful tools for multithreaded applications.

Upvotes: 2

Alex Gitelman
Alex Gitelman

Reputation: 24722

All other comments are good, I just want to add - make sure that you called flush() on your output streams before closing them.

Upvotes: 0

sepo
sepo

Reputation: 404

Use the finally block to add your flushing instructions.

Upvotes: 0

Related Questions