Gizmodo
Gizmodo

Reputation: 3252

Metal Vertex Shader Warning in Swift 5

I got this passthrough vertex shader I used from Apple's sample code:

vertex VertexIO vertexPassThrough(device packed_float4 *pPosition  [[ buffer(0) ]],
                                  device packed_float2 *pTexCoords [[ buffer(1) ]],
                                  uint                  vid        [[ vertex_id ]])
{
    VertexIO outVertex;

    outVertex.position = pPosition[vid];
    outVertex.textureCoord = pTexCoords[vid];

    return outVertex;
}

This worked in Swift 4/Xcode 10/iOS 12. Now I with Swift 5/Xcode 11/iOS 13, I get this warning:

writable resources in non-void vertex function

Upvotes: 13

Views: 1894

Answers (1)

trojanfoe
trojanfoe

Reputation: 122449

You need to ensure the shader can only read from those buffers, so you need to change the declaration to const device:

vertex VertexIO vertexPassThrough(const device packed_float4 *pPosition  [[ buffer(0) ]],
                                  const device packed_float2 *pTexCoords [[ buffer(1) ]],
                                  uint                  vid        [[ vertex_id ]])
{
...
}

Upvotes: 21

Related Questions