CODEWITHSUNDEEP
objective-ccocoastring
draion
draion

Reputation: 443

Converting Decimal to String to Decimal

I copied this code from another post. I tried the example, however, I am getting a EXEC_BAD_ACCESS. From what I have read, this error happens when trying to use an object that has been deallocated, but I just don't see where I am doing that:

The call ...

float weighted_average = num_of_passes / total_of_all_passes;
NSString *newNumber = [[NSString alloc] init];
newNumber = [self formattedStringWithDecimal:weightedAverage]; //weighted average (float) = 15.875145

...

The Function

- (NSString *)formattedStringWithDecimal:(NSDecimalNumber *)decimalNumber
{
    NSNumberFormatter *formatter = [[NSNumberFormatter alloc] init];
    [formatter setMaximumFractionDigits:2]; //two deimal spaces
    [formatter setRoundingMode: NSNumberFormatterRoundHalfUp]; //round up


   NSString *result =[NSString stringWithString:[formatter stringFromNumber:decimalNumber]];
    [formatter release];
    return result;
}

Upvotes: 1

Views: 4334

Answers (2)

Nick Weaver
Nick Weaver

Reputation: 47241

Call the method like this:

newNumber = [self formattedStringWithDecimal:[NSDecimalNumber numberWithFloat:15.434]];

You've tried to pass a primitive, but the method expects an object: an NSDecimalNumber. You've got to use the static convenience method numberWithFloat to create an object of that type.

And by the way, I have the feeling that 

newNumber = [NSString stringWithFormat@"%.2f", 15.434];

could achieve the same result with less lines of code. Note this will not round up your number though.

Upvotes: 2

David Neiss
David Neiss

Reputation: 8237

You are returning an autoreleased object. Does the function that uses it retain it? If not, it could be released and then later (later run loop) its trying to be (re)used. Agreed on the enabling zombies to spot that kind of thing.

Upvotes: 1

Related Questions