Android Data Binding not Update UI after retreive data from webservice

Question

I try to implement MVVM by Mindorks to show data from here :(https://api.themoviedb.org/3/movie/384018?api_key=67bc513a7a353631119fdffe5f7377a8&language=en-US) in my Activity. I try using databinding for update UI, but after the data is update, databinding not update my textview. here my Detail Activity Class :

   public class DetailActivity extends BaseActivity implements DetailNavigator {
@Inject
DetailViewModel detailViewModel;

public static final String INTENT_ID = "id_intent";

public static final String INTENT_FLAG = "id_flag";

private ActivityDetailBinding mActivityDetailBinding;

public static Intent newIntent(Context context) {
    return new Intent(context, DetailActivity.class);
}

@Override
public int getBindingVariable() {
    return BR.viewModel;
}

@Override
public int getLayoutId() {
    return R.layout.activity_detail;
}

@Override
public DetailViewModel getViewModel() {
    return detailViewModel;
}

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_detail);
    detailViewModel.setNavigator(this);
    mActivityDetailBinding = getViewDataBinding();
    initView();
    initData(savedInstanceState);

}


private void initData(Bundle savedInstanceState) {
    Bundle extras = getIntent().getExtras();
    if (extras != null) {
        int id = extras.getInt(INTENT_ID, 0);
        int flag = extras.getInt(INTENT_FLAG, 0);
        detailViewModel.fetchDetail(id, flag);
    }
}

private void initView() {
    if (getSupportActionBar() != null) {
        getSupportActionBar().hide();
    }
    getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN, WindowManager.LayoutParams.FLAG_FULLSCREEN);
}


@Override
public void ShowProgressDialog(Boolean loading) {
    if (loading) {
        showLoading();
    } else {
        hideLoading();
    }
}
}

and my BaseActivity like this :

   public abstract class BaseActivity extends AppCompatActivity
        implements BaseFragment.Callback {

    // TODO
    // this can probably depend on isLoading variable of BaseViewModel,
    // since its going to be common for all the activities
    private ProgressDialog mProgressDialog;
    private T mViewDataBinding;
    private V mViewModel;

    /**
     * Override for set binding variable
     *
     * @return variable id
     */
    public abstract int getBindingVariable();

    /**
     * @return layout resource id
     */
    public abstract
    @LayoutRes
    int getLayoutId();

    /**
     * Override for set view model
     *
     * @return view model instance
     */
    public abstract V getViewModel();

    @Override
    public void onFragmentAttached() {

    }

    @Override
    public void onFragmentDetached(String tag) {

    }

    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        performDependencyInjection();
        super.onCreate(savedInstanceState);
        performDataBinding();
    }

    public T getViewDataBinding() {
        return mViewDataBinding;
    }

    @TargetApi(Build.VERSION_CODES.M)
    public boolean hasPermission(String permission) {
        return Build.VERSION.SDK_INT < Build.VERSION_CODES.M ||
                checkSelfPermission(permission) == PackageManager.PERMISSION_GRANTED;
    }

    public void hideKeyboard() {
        View view = this.getCurrentFocus();
        if (view != null) {
            InputMethodManager imm = (InputMethodManager) getSystemService(Context.INPUT_METHOD_SERVICE);
            if (imm != null) {
                imm.hideSoftInputFromWindow(view.getWindowToken(), 0);
            }
        }
    }

    public void hideLoading() {
        if (mProgressDialog != null && mProgressDialog.isShowing()) {
            mProgressDialog.cancel();
        }
    }

    public void showLoading() {
        hideLoading();
        mProgressDialog = CommonUtils.showLoadingDialog(this);
    }

    public boolean isNetworkConnected() {
        return NetworkUtils.isNetworkConnected(getApplicationContext());
    }

    public void performDependencyInjection() {
        AndroidInjection.inject(this);
    }

    @TargetApi(Build.VERSION_CODES.M)
    public void requestPermissionsSafely(String[] permissions, int requestCode) {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
            requestPermissions(permissions, requestCode);
        }
    }

//    public void showLoading() {
//        hideLoading();
//        mProgressDialog = CommonUtils.showLoadingDialog(this);
//    }

    private void performDataBinding() {
        mViewDataBinding = DataBindingUtil.setContentView(this, getLayoutId());
        this.mViewModel = mViewModel == null ? getViewModel() : mViewModel;
        mViewDataBinding.setVariable(getBindingVariable(), mViewModel);
        mViewDataBinding.setLifecycleOwner(this);
        mViewDataBinding.executePendingBindings();
    }
    @Override
    protected void onResume() {
        super.onResume();
    }

    @Override
    protected void onDestroy() {
        super.onDestroy();
    }
}

this is my ViewModel class :

public class DetailViewModel extends BaseViewModel {

private final ObservableField originalName = new ObservableField<>();
private final ObservableField releaseDate = new ObservableField<>();
private final ObservableField overview = new ObservableField<>();
private final ObservableField genreMovie = new ObservableField<>();
private final ObservableField posterPath = new ObservableField<>();
private final ObservableField voteAverage = new ObservableField<>();

public DetailViewModel(DataManager dataManager, SchedulerProvider schedulerProvider) {
    super(dataManager, schedulerProvider);
}

public void fetchDetail(int id, int flag) {
    if (flag == 1) {
        getNavigator().ShowProgressDialog(true);
        getCompositeDisposable().add(getDataManager()
                .getApiHelper().doDetailMovie(id, URLConfig.API_KEY, getDataManager().getLanguage())
                .subscribeOn(getSchedulerProvider().io())
                .observeOn(getSchedulerProvider().ui())
                .subscribe(detailResponse -> {
                    setUpData(detailResponse);
                    getNavigator().ShowProgressDialog(false);
                }, throwable -> {
                    getNavigator().ShowProgressDialog(false);
                }));
    } else if (flag == 2) {
        getNavigator().ShowProgressDialog(true);
        getCompositeDisposable().add(getDataManager()
                .getApiHelper().doDetailTV(id, URLConfig.API_KEY, getDataManager().getLanguage())
                .subscribeOn(getSchedulerProvider().io())
                .observeOn(getSchedulerProvider().ui())
                .subscribe(detailResponse -> {
                    setUpData(detailResponse);
                    getNavigator().ShowProgressDialog(false);
                }, throwable -> {
                    getNavigator().ShowProgressDialog(false);
                }));
    }
}

private void setUpData(DetailResponse detailResponse) {
    if (detailResponse.getOriginal_name() != null) {
        originalName.set(detailResponse.getOriginal_name());
    } else {
        originalName.set(detailResponse.getOriginal_title());
    }
 originalName.notifyChange();
    if (detailResponse.getFirst_air_date() != null) {
        releaseDate.set(detailResponse.getFirst_air_date());
    } else {
        releaseDate.set(detailResponse.getRelease_date());
    }
    overview.set(String.valueOf(detailResponse.getOverview()));

    posterPath.set(String.valueOf(detailResponse.getPoster_path()));

    voteAverage.set(String.valueOf(detailResponse.getVote_average()));

    String genres = "";

    for (int i = 0;i getOriginalName() {
    return originalName;
}

public ObservableField getReleaseDate() {
    return releaseDate;
}

public ObservableField getOverview() {
    return overview;
}

public ObservableField getGenreMovie() {
    return genreMovie;
}

public ObservableField getPosterPath() {
    return posterPath;
}

public ObservableField getVoteAverage() {
    return voteAverage;
}
}

and this is my DetailResponse Class :

public class DetailResponse {
    @SerializedName("original_name")
    private String original_name ;
    @SerializedName("original_title")
    private String original_title ;
    @SerializedName("release_date")
    private String release_date ;
    @SerializedName("first_air_date")
    private String first_air_date ;
    @SerializedName("vote_average")
    private Double vote_average ;
    @SerializedName("overview")
    private String overview ;
    @SerializedName("poster_path")
    private String poster_path;
    @SerializedName("genres")
    private List genreList;

    public String getOriginal_name() {
        return original_name;
    }

    public String getOriginal_title() {
        return original_title;
    }

    public String getRelease_date() {
        return release_date;
    }

    public String getFirst_air_date() {
        return first_air_date;
    }

    public Double getVote_average() {
        return vote_average;
    }

    public String getOverview() {
        return overview;
    }

    public String getPoster_path() {
        return poster_path;
    }

    public List getGenreList() {
        return genreList;
    }

    public static class Genre{
        @SerializedName("name")
        private String name ;

        public String getName() {
            return name;
        }
    }
}

and last one, here how I try to get data in my UI using databinding, this is my layout :

I try to show one data first, that is OriginalName for text_title, went I debug my application

public ObservableField getOriginalName() {
    return originalName;
}

getOriginalName in class ViewModel, just called before I retrieve my response, but after OriginalName is set, the UI not update and getOriginalName is never called again.I already add originalName.notifyChange(); after the data is set, but it doesn't seem change anything.

I already frustased.. so please... I hope anybody can help me to show me what to do. Thank you very much.

Rajnish suryavanshi · Accepted Answer

Remove this below line from Detail Activity

setContentView(R.layout.activity_detail);

In your base activity you have performDataBinding method which set the layout id using DataBindingUtil class.

    mViewDataBinding = DataBindingUtil.setContentView(this, getLayoutId());
    this.mViewModel = mViewModel == null ? getViewModel() : mViewModel;
    mViewDataBinding.setVariable(getBindingVariable(), mViewModel);
    mViewDataBinding.setLifecycleOwner(this);
    mViewDataBinding.executePendingBindings();

Android Data Binding not Update UI after retreive data from webservice

Answers (1)

Related Questions