CODEWITHSUNDEEP
githubpull-request
user1893354
user1893354

Reputation: 5938

In Github, are PR reviewers notified when a new commit has been made after they request changes?

I'm not sure if this is an appropriate question for SO but say I make a PR in Github and the reviewers of the PR request changes before it is merged. When I subsequently commit the requested changes on my branch that I am trying to merge are the reviewers notified that I have made the change? Or do I need to explicitly comment on the PR that I have made the change and tag the reviews?

Upvotes: 2

Views: 3979

Answers (2)

VonC
VonC

Reputation: 1323413

Since February 2019, no need to comment: you can Re-request review on a pull request

If changes have been made to a pull request that has already been reviewed, you can now re-request a review with a single click in the pull request’s sidebar. This will notify the requested reviewers that changes have been made.

Upvotes: 1

Matthew Liu
Matthew Liu

Reputation: 319

When I subsequently commit the requested changes on my branch that I am trying to merge are the reviewers notified that I have made the change?

They will be able to see/notified you made a new commit, but they won't know if it addresses the PR concerns (or if you're simply adding unrelated changes). Best practice is to comment on the PR and tell them you made changes - tagging the reviewer(s) definitely won't hurt!

Upvotes: 2

Related Questions