CODEWITHSUNDEEP
javascriptgoogle-apps-scriptgoogle-sheetsrefactoring
Pavel Zakharenko
Pavel Zakharenko

Reputation: 13

How to make function simple

Maybe delete some logical Operators, make a "Check function "?

Or connect some logical in one piece?

// Function 

function getTicketPrice(childNumber,adultNumber){

  if (childNumber > 2 && adultNumber > 2) {
    return "-";
  }
    if (childNumber == 2 && adultNumber == 3) {
    return "-";
  }
    if (childNumber == 3 && adultNumber == 2) {
    return "-";
  }  

  var sheet = SpreadsheetApp.openByUrl(url).getSheetByName("Ticket");  
  var row = getTicketPriceChild(childNumber, sheet);
  var col = getTicketPriceAdult(adultNumber, sheet);

    if (row >-1 && col === undefined) {
    return "-";
  }
    if (row === undefined && col >-1) {
    return "-";
  }    

  var value = sheet.getRange(row, col).getValue();

    if(value > 1){
    return value;
  } else {
    return '-';
  }
}

Upvotes: 0

Views: 68

Answers (1)

Konstantin Baklaev
Konstantin Baklaev

Reputation: 323

Something like this:

function getTicketPrice(childNumber, adultNumber) {
  if ((childNumber > 2 && adultNumber > 2) || (childNumber == 2 && adultNumber == 3) || (childNumber == 3 && adultNumber == 2))
    return "-";

  const sheet = SpreadsheetApp.openByUrl(url).getSheetByName('Ticket');
  const row = getTicketPriceChild(childNumber, sheet);
  const col = getTicketPriceAdult(adultNumber, sheet);

  if ((row > -1 && col === undefined) || (row === undefined && col > -1))
    return "-";

  const value = sheet.getRange(row, col).getValue();
  return value > 1 ? value : "-"
}

Upvotes: 3

Related Questions