CODEWITHSUNDEEP
javasonarqube
RKCY
RKCY

Reputation: 4135

SonarQube - May Expose Internal Representation by storing an external mutable object

the below code is giving an error when running through SonalQube for code Vulnerability.

public class Myclass{

String[] text;

public MyClass(String [] texts){
this.texts = texts;
}
}

The above code is throwing vulnerability error: May Expose Internal Representation by storing an external mutable object

Upvotes: 2

Views: 2120

Answers (2)

Mujammil Mulla
Mujammil Mulla

Reputation: 1

But each time you create a copy when using Arrays.copyOf(), a new array object is allocated in memory. I would suggest you just use the SuppressWarning annotation.

Upvotes: 0

Mobold
Mobold

Reputation: 595

As already mentioned in the comments, arrays are passed by Reference in Java (as all complex Objects). This means there is the oportiunity to pass a valid Sting[] to your class and after you checked it and stored it, the caller changes the content of the array to what ever he wants.

So if you want to close thie vulnerabilitity you need to store the array like this:

public class SaveArrayContainer {

public String[] data;

    public SaveArrayContainer(String[] array) {
        data = Arrays.copyOf(array, array.length);
    }
}

Upvotes: 1

Related Questions