Color converter binding not being called

Question

I have a label with black text color inside a frame with white background color, the thing is, I want to assign the background color and text color from the viewmodel, I have created the converter, and did the bindings, but for some reason it isn't working

this is my view code:

?xml version="1.0" encoding="UTF-8"?>

Here is my ViewModel:

public class PlatillosViewModel : INotifyPropertyChanged
{
    private INavigation Navigation;
    private ObservableCollection _platillos;
    private string _textColor;
    private string _backColor;
    public event PropertyChangedEventHandler PropertyChanged;
    public ObservableCollection Grupos { get; set; }
    public ObservableCollection Platillos
    {
        get => _platillos;
        set
        {
            _platillos = value;
            OnPropertyChanged();
        }
    }

    public string TextColor
    {
        get => _textColor;
        set
        {
            _textColor = value;
            OnPropertyChanged();
        }
    }

    public string ButtonBackColor
    {
        get => _backColor;
        set
        {
            _backColor = value;
            OnPropertyChanged();
        }
    }

    public PlatillosViewModel(INavigation navigation)
    {
        Navigation = navigation;
        TextColor = "Black";
        ButtonBackColor = "White";
        PlatillosRepository repository = new PlatillosRepository();
        Platillos = repository.GetAll();
        GrupoRepository grupoRepository = new GrupoRepository();
        Grupos = grupoRepository.GetAll();
    }

    public ICommand SelectedPlatilloCommand => new Command(async platillo =>
    {
        await Navigation.PushAsync(new PlatilloView());
    });

    public ICommand SelectedGrupoCommand => new Command(async grupo =>
    {
        ButtonBackColor = "Black";
        TextColor = "White";
        PlatillosRepository platillosRepository = new PlatillosRepository();
        Platillos = platillosRepository.GetFilteredByGroup(grupo);
    });

    protected virtual void OnPropertyChanged([CallerMemberName] string property = "")
    {
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(property));
    }
}

and Here is my converter:

public class ColorConverter : IValueConverter
{
    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
    {
        var valor = value.ToString();
        switch(valor)
        {
            case "White":
                return Color.White;
            case "Black":
                return Color.Black;
            default:
                return Color.Red;
        }
    }

    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
    {
        return null;
    }
}

pinedax · Accepted Answer

Your issue is not with the ValueConverter but with your Bindings.

You are using a CollectionView and when you set the ItemSource



All the bindings you do inside will assume this as the BindingContext. 




The same way the nombre property you are binding to the Label Text Property, is part of the GroupModel class, that way the TextColor and ButtonBackColor properties are expected to be part of the same class you did bind as the ItemSource.

If you want to make it work: either add these two properties (TextColor and ButtonBackColor) to the GroupModel class or change the binding so that these two properties are accessed from the parent Binding.

The first one will give you more flexibility but at the same time might add repeated code (if all the items will share the same color for example).

The second option can be accomplished this way:

Add a name to the CollectionView



Then we are gonna change a bit the binding of those items that are not part of your GrupoModel but are part of the ViewModel


    
        
            
                
                
            
        
    



As you can see we are now accessing them through the CollectionView Binding, we do this when we specify the Source and use a Reference. More about bindings here 

Hope this helps.-

Side Note:

In your converter watch for nulls.

var valor = value.ToString();


The above can make your application crash if value is null. 

Use this instead:

var valor = value?.ToString();

Color converter binding not being called

Answers (1)

Related Questions