CODEWITHSUNDEEP
javascriptsonarqube
Karan
Karan

Reputation: 359

How can I reduce cyclomatic complexity for the code to be acceptable by sonar

This function is not working as expected in the sonar

Upvotes: 0

Views: 3098

Answers (2)

Kumar Shanoo
Kumar Shanoo

Reputation: 135

A quick fix will be to extract methods into smaller method and avoid if else with switch statement or by polymorphisms.

Upvotes: 0

Jacob
Jacob

Reputation: 78900

A simplified way of thinking of Sonar's cyclomatic complexity metric would be "how many logical branches and loops do I have to reason about to understand this function?" There are a few approaches you can take:

  1. Split your function up. If the function is doing multiple things, try splitting each thing out into its own function
  2. Reduce branches in your code. Often times, an if/else statement can be a conditional assignment instead.

Cyclomatic complexity doesn't even cover some other things hard to follow in your code:

  1. You are often duplicating segments code instead of storing things off in temporary variables. Duplicating code not only makes someone reading the code have more work to do, but it also means you're forcing the program to do this extra work.
  2. Because you're using var throughout, someone reading your code has to look through your entire function to know whether or not a variable will be reassigned at different points. Using const when something won't change lets us know whether we don't have to worry about this any longer.
  3. Some of your if statement conditions are complex. Try to refactor them into more readable temporary variables.

Here's my stab at reducing your cyclomatic complexity and code readability:

function validateSignInForm(signinErrorMessage) {
  let bFinalSubmit = true;

  if (!validateFields()) {
    bFinalSubmit = false;
  }

  const errMainError = (typeof signinErrorMessage === 'undefined')
    ? configuration.messages.signinIncomplete;
    : signinErrorMessage;
  if (errMainError === configuration.messages.notFound) {
    trp.fai.common.log(errMainError);
    bFinalSubmit = false;
  }

  const errMsg = $('#signin-mainerr-message');
  const errContainer = $('#signin-ui-notification-container-mainerr');
  if (!bFinalSubmit) {
    errMsg.html(errMainError);
    errContainer.show();
  } else {
    errMsg.html('');
    errContainer.hide();
  }

  return bFinalSubmit;
}

function validateFields() {
  let canSubmit = true;

  configuration.required.signin.forEach(field => {
    const fieldName = field.name;
    const fieldValue = $.trim(field.value);
    const fieldElement = $('#' + fieldName);
    const fieldLabel = fieldElement
      .closest('li')
      .find('label')

    if (
      (fieldValue === '' || (fieldName === 'username' && fieldValue === 'Your email address')) 
      && $('#' + field.id).is(':visible')
    ) {
      fieldElement.addClass('ui-red-border');
      fieldLabel.addClass('ui-red-text');
      canSubmit = false;
    } else {
      fieldElement.removeClass('ui-red-border');
      fieldLabel.removeClass('ui-red-text');
      $('#' + fieldName + 'Field').removeClass('registerFieldError');

      if (configuration.required.signin[i].onchange) {
        configuration.required.signin[i].onchange();
      }
    }
  });

  return canSubmit;
}

Upvotes: 2

Related Questions