CODEWITHSUNDEEP
phparraysstring
med
med

Reputation: 469

Convert comma separated string into array

I have a comma separated string, which consists of a list of tags and want to convert it to array to get a link for every tag.

Example:

$string = 'html,css,php,mysql,javascript';

I want to make it like this:

<a href="tag/html">html</a>, <a href="tag/css">css</a>, <a href="tag/php">php</a>, <a href="tag/mysql">mysql</a>, <a href="tag/javascript">javascript</a>

So the result will be a string containing comma separated links with a space after each link and with no comma after the last link.

I have this function where $arg = 'html,css,php,mysql,javascript':

function info_get_tags( $arg ) {
    global $u;

    $tagss = '';
    if ( $arg == '' ) {
        return '';
    } else {
        $tags_arr = explode( ',' , $arg );
        foreach ( $tags_arr as $tag ) {
            $tags = '<a href="' . $u . 'tag/' . $tag . '/" title="' . $tag . '">' . $tag . '</a>';
            $tagss .= $tags;
        }

        return $tagss;
    }
}

This script works for me but without commas and spaces and if we add a comma and a space here:

$tags = '<a href="' . $u . 'tag/' . $tag . '/">' . $tag . '</a>, ';

we get commas and spaces but there will be a trailing comma after the last link.

Upvotes: 10

Views: 36971

Answers (10)

Alphons
Alphons

Reputation: 323

$string = 'html,css,php,mysql,javascript';

puts $string.split(/,/).map { |tag| "<a href=\"tag/#{tag}\">#{tag}</a>"}.join(", ")

result:

<a href="tag/html">html</a>, <a href="tag/css">css</a>, <a href="tag/php">php</a>, <a href="tag/mysql">mysql</a>, <a href="tag/javascript">javascript</a>

Upvotes: 0

Cross
Cross

Reputation: 13

Try this short code

$string = 'html,css,php,mysql,javascript';

$string = explode(',', $string);
   foreach( $string as $link){
   echo '<a href="tag/'.$link.'">'.$link.'</a>';
}

Upvotes: 1

Rudie
Rudie

Reputation: 53781

Another solution:

$html = trim(preg_replace('/([^,]+)/', ' <a href="/tags/\1" title="\1">\1</a>', $string));

Or if you have to html encode the tags (always smart, since you're creating html from text):

$html = trim(preg_replace_callback('/([^,]+)/', function($match) {
    $tag = $match[1];
    return ' <a href="/tags/' . urlencode($tag) . '" title="' . htmlspecialchars($tag) . '">' . htmlspecialchars($tag) . '</a>';
}, $string));

So this $string would work too: "tag with space,html,css,php,mysql,javascript"

More regex is always good!

Upvotes: -3

Nick
Nick

Reputation: 8530

Here's an alternative that uses array_map instead of the foreach loop:

global $u; 
function add_html($tag){
    return('<a href="' . $u . 'tag/' . $tag . '/" title="' . $tag . '">' . $tag .  '</a>');
}
function get_tags($taglist){
    $tags_arr = array_map("add_html", explode( ',' , $taglist));
    return implode(", " , $tags_arr);
}

Upvotes: 2

Narf
Narf

Reputation: 14752

function info_get_tags($arg)
{
    global $u;
    if (empty($arg)) return '';
    return ltrim(preg_replace('/([^\,]+)/', ' <a href="' . $u . '/${1}/" title="${1}">${1}</a>', $arg));
}

Upvotes: 0

NikiC
NikiC

Reputation: 101906

Just like you exploded you can implode again:

$tags = explode(',', $arg);
foreach ($tags as &$tag) {
    $tag = '<a href="' . $u . 'tag/' . $tag . '/" title="' . $tag . '">' . $tag . '</a>';
}

return implode(', ', $tags);

Upvotes: 17

mario
mario

Reputation: 145482

The workaround(!) would be to remove the unwanted trailing characters afterwards:

$tagss = rtrim($tagss, ", ");

This rtrim removes any mix of spaces and commas from the right end of the string.

Btw, you could use str_getcsv instead of explode, which also handles input spaces better.

Upvotes: 0

Arjan
Arjan

Reputation: 9874

Why not put all tags in an array when you are creating them, and later explode the array and add the commas and spaces between the tags.

foreach ( $tags_arr as $tag ) {
    $tags = '<a href="' . $u . 'tag/' . $tag . '/" title="' . $tag . '">' . $tag . '</a>';
    $tagss[] = $tags;
}
$tagss = explode(', ', $tagss);

Upvotes: 0

Igor
Igor

Reputation: 2659

Try this 

$tagss = trim($tagss);    
return substr($tagss, 0 , strlen($tagss)-1);

Upvotes: 0

prodigitalson
prodigitalson

Reputation: 60413

Easiest way is to the html into an array (each tag link is an array element) and then implode on ,...

if ( $arg == '' ) {

    return '';

} else {

    $tags_arr = explode( ',' , $arg );
    $tags  = array();
    $tagtpl = '<a href="%s" title="%s">%s</a>';

    foreach ( $tags_arr as $tag ) {
        $url = $u . 'tag/' . $tag . '/';
        $tags[] = sprintf($tagtpl, $url, $tag, $tag);

    }

    return implode(', ', $tags);

}

Upvotes: 0

Related Questions