CODEWITHSUNDEEP
sqloracle-databaseplsqlsqlplus
Shashwat Srivastava
Shashwat Srivastava

Reputation: 15

How to get rid of compilation error in PL/SQL procedure?

Being new to PL/SQL, I am unable to understand how to manage user-defined exceptions in procedures. My code is giving the Warning 'Procedure created with compilation errors'.

CREATE OR REPLACE PROCEDURE raise_salary
(eid IN employees.e_id%TYPE:=&emp_id,
raise IN employees.salary:=&salary_raise)
IS
cnt INTEGER;
salary employees.salary%TYPE;
BEGIN
    SELECT count(*) INTO cnt FROM employees WHERE e_id=eid;
    IF cnt=0 THEN
        RAISE INVALID_ID;
    ELSE
        SELECT salary INTO sal FROM employees WHERE e_id=eid;
        IF sal IS NULL THEN
            RAISE NULL_VALUE;
        ELSE
            UPDATE employees SET salary=salary+raise WHERE e_id=eid;
            dbms_output.put_line('Salary raised!');
        END IF;
    END IF;
EXCEPTION
    WHEN INVALID_ID THEN
        dbms_output.put_line('User ID does not exist!');
    WHEN NULL_VALUE THEN
        dbms_output.put_line('Salary is null in table!');
    WHEN others THEN
        dbms_output.put_line('Error!');
END;
/

Upvotes: 0

Views: 2202

Answers (2)

VBoka
VBoka

Reputation: 9083

In this DEMO you will see all 3 situation that this PROCEDURE should handle:

Here is the correct procedure:

CREATE OR REPLACE PROCEDURE raise_salary
(eid IN employees.e_id%TYPE,
raise IN employees.salary%type)
IS

cnt INTEGER;
sal employees.salary%TYPE;
INVALID_ID exception;
NULL_VALUE exception;

BEGIN

 SELECT count(*) 
 INTO cnt 
 FROM employees 
 WHERE e_id=eid;

 IF cnt=0 THEN
     RAISE INVALID_ID;
 ELSE    
     SELECT salary 
     INTO sal 
     FROM employees 
     WHERE e_id=eid;

     IF sal IS NULL THEN
            RAISE NULL_VALUE;
        ELSE
            UPDATE employees 
            SET salary = (SAL + raise)
            WHERE e_id = eid;

            dbms_output.put_line('Salary raised!');
     END IF;    
 END IF;

exception
 WHEN INVALID_ID THEN
     dbms_output.put_line('User ID does not exist!');
 WHEN NULL_VALUE THEN
     dbms_output.put_line('Salary is null in table!');
 WHEN others THEN
     dbms_output.put_line('Error!');
END;
/

You had more than one errors and one was nicely explained by @Aleksej in his answer VOTE UP. You also have a line:

SELECT salary INTO sal FROM employees WHERE e_id=eid;

But you have not declared sal. Hope this helps...

Upvotes: 1

Aleksej
Aleksej

Reputation: 22969

An example:

SQL> CREATE OR REPLACE PROCEDURE testException
  2  IS
  3  BEGIN
  4      raise INVALID_ID;
  5  EXCEPTION
  6      WHEN INVALID_ID THEN
  7          dbms_output.put_line('Invalid ID');
  8  END;
  9  /

Warning: Procedure created with compilation errors.

A way to know the errors:

SQL> sho err
Errors for PROCEDURE TESTEXCEPTION:

LINE/COL ERROR
-------- -----------------------------------------------------------------
0/0      PL/SQL: Compilation unit analysis terminated
4/5      PL/SQL: Statement ignored
4/11     PLS-00201: identifier 'INVALID_ID' must be declared
6/10     PLS-00201: identifier 'INVALID_ID' must be declared

You need to declare the exceptions you use:

SQL> CREATE OR REPLACE PROCEDURE testException
  2  IS
  3      INVALID_ID exception;
  4  BEGIN
  5      raise INVALID_ID;
  6  EXCEPTION
  7      WHEN INVALID_ID THEN
  8          dbms_output.put_line('Invalid ID');
  9  END;
 10  /

Procedure created.

Upvotes: 2

Related Questions