PHP MySQL Insert Problem

Question

$dbHost = "localhost"; 
$dbUsr = "root"; 
$dbPass = "";

function register() { 
  $username = md5($_POST['username']); 
  $password = md5($_POST['password']); 
  $remote = md5($_SERVER['REMOTE_ADDR']);

  $connect = mysql_connect("$dbHost", "$dbUsr", "$dbPass");
  mysql_select_db("drupia1", $connect);

  $query = sprintf('INSERT INTO usrs
                      (username, password, ip)
                    VALUES
                      ("$username", "$password", "$remote"', mysql_real_escape_string($username), mysql_real_escape_string($password));
}

Why is it this script and any other way I write it, the values in mysql seem to be 0?

Answer 1

Consult php.net for using sprintf - it should resemble:

$query = sprintf("INSERT INTO usrs 
                    (username, password, ip) 
                  VALUES
                    ('%s', '%s', '%s' )", 
                  mysql_real_escape_string($username), 
                  mysql_real_escape_string($password),
                  $remote);