CODEWITHSUNDEEP
python-3.x
HelpMe
HelpMe

Reputation: 3

how to add characters from array into one string python

I'm trying to change characters from x into upper or lower character depending whether they are in r or c. And the problem is that i can't get all the changed characters into one string. 

import unittest

def fun_exercise_6(x):
    y = []
    r = 'abcdefghijkl'
    c = 'mnopqrstuvwxz'
    for i in range(len(x)):
        if(x[i] in r):
            y += x[i].lower()
        elif(x[i] in c):
            y += x[i].upper()
    return y


class TestAssignment1(unittest.TestCase):
    def test1_exercise_6(self):
        self.assertTrue(fun_exercise_6("osso") == "OSSO")
    def test2_exercise_6(self):
        self.assertTrue(fun_exercise_6("goat") == "gOaT")
    def test3_exercise_6(self):
        self.assertTrue(fun_exercise_6("bag") == "bag")
    def test4_exercise_6(self):
        self.assertTrue(fun_exercise_6("boat") == "bOaT" )

if __name__ == '__main__':
    unittest.main()

Upvotes: 0

Views: 263

Answers (3)

dmic
dmic

Reputation: 11

Using a list as you are using is probably the best approach while you are figuring out whether or not each character should be uppered or lowered. You can join your list using str's join method. In your case, you could have your return statement look like this:

return ''.join(y)

What this would do is join a collection of strings (your individual characters into one new string using the string you join on ('').

For example, ''.join(['a', 'b', 'c']) will turn into 'abc'

This is a much better solution than making y a string as strings are immutable data types. If you make y a string when you are constructing it, you would have to redefine and reallocate the ENTIRE string each time you appended a character. Using a list, as you are doing, and joining it at the end would allow you to accumulate the characters and then join them all at once, which is comparatively very efficient.

Upvotes: 1

Riccardo Bucco
Riccardo Bucco

Reputation: 15374

You can't compare a list and a string.

"abc" == ["a", "b", "c'] # False

The initial value of y in the fun_exercise_6 function must be ""

Upvotes: 0

Erik
Erik

Reputation: 84

If you define y as an empty string y = "" instead of an empty list you will get y as one string. Since when you declare y = [] and add an item to the list, you add a string to a list of string not a character to a string.

Upvotes: 0

Related Questions