CODEWITHSUNDEEP
c++winapifile-management
Mike
Mike

Reputation: 89

Why does CreateFile return invalid handle?

I have CreateFile() to create a hidden file type but the problem that it keeps returning invalid handle. 

file = CreateFileW(_T("hey.txt"),
                   GENERIC_WRITE, 0, NULL, CREATE_ALWAYS,
                   0, 0);
error = GetLastError();
WriteFile(file, buff, sizeof(buff),
          &dwRet, NULL);

Any idea?

Upvotes: 0

Views: 18356

Answers (3)

Jabberwocky
Jabberwocky

Reputation: 50912

If "C:\test.txt" exists and is hidden, then following code fails (h = INVALID_HANDLE_VALUE) :

h = CreateFile("C:\\test.txt", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0);

this fails too (argument 6 == FILE_ATTRIBUTES_NORMAL or argument6 == 0 seems so be the same) :

h = CreateFile("C:\\test.txt", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0);

but this works :

h = CreateFile("C:\\test.txt", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_HIDDEN, 0);

So roughly in other words : if the file already exists and is hidden then CreateFile with "CREATE_ALWAYS" fails if argument 6 != FILE_ATTRIBUTE_HIDDEN.

Upvotes: 0

Len Holgate
Len Holgate

Reputation: 21644

It would probably be best if you showed the exact code that you're using including all the error checking, and how you do it, is important (especially in the case of this question)...

The correct error checking for your code should be something more like...

file = CreateFile(_T("hey.txt"), GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0);

if (file == INVALID_HANDLE_VALUE)
{
   const DWORD error = GetLastError();

   // Do something!
}
else
{  
   if (!WriteFile(file, buff, sizeof(buff), &dwRet, NULL))
   {
      const DWORD error = GetLastError();

      // Do something!
   }
}

You should only be checking for an error if you get a return value of INVALID_FILE_HANDLE as CreateFile() might not reset the last error before it starts and so you might get spurious error values from GetLastError() if the function succeeds...

A last error of 6, ERROR_INVALID_HANDLE, is unusual from CreateFile() unless you're using the template file parameter, which you're not...

Your code using CreateFileW and _T("") is incorrect and wont compile in a non unicode build. Better to use CreateFile and _T("") or CreateFileW and L"".

Your code will not create a hidden file, see molbdnilo's answer.

Upvotes: 4

molbdnilo
molbdnilo

Reputation: 66459

0 is not a valid parameter for dwFlagsAndAttributes. To create a hidden file, pass FILE_ATTRIBUTE_HIDDEN.

Upvotes: 3

Related Questions