Reputation: 491
I have a class that handles all database methods, including Entity Framework related stuff. When data is needed, other classes may invoke a method in this class such as
public List<LocalDataObject> GetData(int start, int end);
The database is querying using LINQ to EF and the calling class can then iterate over the data. But since other classes have no access to the entities in EF, I need to perform a "ToList()" operation on the query and by that fetching the full dataset into memory.
What will happen if this set is VERY large (10s-100s of GB)?
Is there a more efficient way of doing iteration and still maintain loose coupling?
Upvotes: 19
Views: 19380
Reputation: 177133
Just a quick note about this point:
But since other classes have no access to the entities in EF, I need to perform a "ToList()" operation on the query and by that fetching the full dataset into memory.
The problem you encounter here is in my opinion not related to EF at all. What would you do if you wouldn't use EF for data access but raw ADO.NET? "Having no access to EF" translates then to "Having no access to a database connection".
If you have services or methods which must work with large amounts of objects but cannot access the database - either via EF or another kind of database connection - you must load the data into memory before you pass them to those services/methods. You may then think about solutions to buffer the loaded data somehow on hard disk on client side, but that has nothing to do with the source of the data and how you retrieve them. If you don't buffer and load everything into memory you are limited by your available memory. There is no way to escape from this limitation, I think.
If you have a connection to EF, I think the solution provided in Ladislav's answer is the right one as the settings and procedure he described reduce EF almost to the behaviour of a simple DataReader.
Upvotes: 4
Reputation: 12849
I would use lazy IEnumerable and implement some kind of paging for you data internaly.
Maybe create your own IEnumerable interface, so user of your library is not tempted to call ToList on it himself.
But question is.. is it really good way to hide fact, that user of this data layer would work with such ammounts of data? First thing to do is to limit returned data to bare minimum. Dont return whole entity, but only parts, that you really need. Are you eager-fetching any related entities? Did you thought about using lazy loading?
Upvotes: 0
Reputation: 6465
One way to be certain is to always set an upper threshold that you will return to avoid gigantic set by ending your query with .Take(MAX_ROWS)
. This can be a workaround or a preventive move from a bad call that take down your service but best is to rethink the solution
Upvotes: 0
Reputation: 364259
The correct way to work with large datasets in Entity framework is:
IQueryable<EntityType>
to allow upper layer to specify query more precisely and limit the number of record loaded from databaseIQueryable
set MergeOption.NoTracking
on ObjectQuery
in your data access method. Combining this setting with turned off proxy creation should result in not cached entities and iteration through result of the query should always load only single materialized entity (without caching of loaded entities).In your simple scenario you can always check that client doesn't ask too many records and simply fire exception or return only maximum allowed records.
Upvotes: 22
Reputation: 27441
As much as I like EF for quick/simple data access, I probably wouldn't use it for such a scenario. When dealing with data of that size I'd opt for stored procedures that return exactly what you need, and nothing extra. Then use a lightweight DataReader to populate your objects.
The DataReader provides an unbuffered stream of data that allows procedural logic to efficiently process results from a data source sequentially. The DataReader is a good choice when retrieving large amounts of data because the data is not cached in memory.
Additionally, as far as memory management goes, of course make sure you wrap your code handling unmanaged resources in a using block for proper disposal/garbage collection.
You also may want to consider implementing paging.
Upvotes: 7