CODEWITHSUNDEEP
c++
Palav Patel
Palav Patel

Reputation: 25

Program is meant to count how many duplicates are in an array. However, it returns the wrong frequency values

Normally I would use other methods to fix this program but I am not allowed to use advanced techniques for this project, and so what I have is more or less as far as I'm allowed to go.

So my program is meant to take in an array with 10 numbers and then output how many of each value is in the array. For example, {1, 1, 1, 1, 1, 2, 2, 2, 2, 2} is meant to return

5 1

5 2

However, it returns

6 1

4 2

I've made sure that the finalData and Data arrays are holding the proper values. 

cout << count(data, data + MAX_VALUE, finalData[i+1]) << " " << data[i] << "\n";

seems to be outputting the wrong value.

for some reason. I believe the error is in my last function, getResults, more specifically the last for loop. Here is that function.

void getResults(int finalData[], int data[])
{
    int temp[MAX_VALUE];

    int j = 0;
    for (int i = 0; i < MAX_VALUE - 1; i++)

        if (finalData[i] != finalData[i + 1])
            temp[j++] = finalData[i];


    temp[j++] = finalData[MAX_VALUE - 1];


    for (int i = 0; i < j; i++)
    {
        finalData[i] = temp[i];
    }

    for (int i = 0; i < j; i++)
    {
        cout << count(data, data + MAX_VALUE, finalData[i+1]) << " " << data[i] << "\n";
    }
}

This is my complete code.

#include<iostream>
#include<iomanip>
#include<string>
#include<cmath>
#include <algorithm>

using namespace std;


void printHeader();
int getData(string);
void getResults(int finalData[], int data[]);

const int MAX_VALUE = 10;

int main(void) 
{

    int countValue = 0;
    int freq = 0;

    printHeader();

    int data[MAX_VALUE] = {};
    int frequency[MAX_VALUE] = {};

    for (int i = 0; i < MAX_VALUE; i++)
    {
        cout << "Please enter data position " << i + 1 << "\n";
        data[i] = getData("\nPlease enter a valid integer.\n");

    }

    sort(data, data + MAX_VALUE);

    int values[MAX_VALUE] = {};
    int secondData[MAX_VALUE] = {};

    for (int i = 0; i < MAX_VALUE; i++)
    {
        secondData[i] = data[i];
    }
    getResults(data, secondData);

    return 0;
}

void printHeader()
{

}

int getData(string error)
{
    int userInput = 0;
    do
    {
        cin >> userInput;
        if (cin.fail())
        {
            cout << error;
        }
    } while (cin.fail());
    return userInput;
}

void getResults(int finalData[], int data[])
{
    int temp[MAX_VALUE];

    int j = 0;
    for (int i = 0; i < MAX_VALUE - 1; i++)

        if (finalData[i] != finalData[i + 1])
            temp[j++] = finalData[i];


    temp[j++] = finalData[MAX_VALUE - 1];


    for (int i = 0; i < j; i++)
    {
        finalData[i] = temp[i];
    }

    for (int i = 0; i < j; i++)
    {
        cout << count(data, data + MAX_VALUE, finalData[i+1]) << " " << data[i] << "\n";
    }
}

Got the right answer. Made the changes I listed at the top as well as the following change to the count function.

        cout << count(data, data + MAX_VALUE, finalData[i]) << " " << finalData[i] << "\n";

Upvotes: 0

Views: 45

Answers (1)

Zig Razor
Zig Razor

Reputation: 3495

You have done a simple error. When you call getResults you pass the same array(pointer) to 2 different parameters. Now when you update finalData the unwanted side effect update also data(they are the same pointer(with different name). So when you call count will not return the expected result.

To solve this problem you can do a copy of the input array and give it as second parameter of getResults(...) function.

Upvotes: 1

Related Questions