CODEWITHSUNDEEP
javascripthtml
cacowa1
cacowa1

Reputation: 21

JavaScript - Checkbox loop not totalling up prices correctly

When I click on the checkbox at the top, it puts a '0' in the total box, so I know that it is connected correctly, however I think there is a problem in the logic in the loop. One of the elements in html looks like this.

const form = document.getElementById('bookingForm');
const total = document.getElementById('total');
const checkboxes = document.querySelectorAll('input[data-price][type=checkbox]');
const cbamount = checkboxes.length;

document.getElementsByName('event[]')[0].onclick = function() {
  totalPrice()
};

function totalPrice() {
  let totalprice = 0;
  for (let i = 0; i < cbamount; i++) {
    const box = checkboxes[i];
    if (box.checked) {
      box.dataset.price = totalprice + box.dataset.price;
    } //if
  } //for

  document.getElementsByName("total")[0].value = totalprice;
}
<span class="eventTitle">Carmen </span>
<span class="eventStartDate">2020</span>
<span class="eventEndDate">2020</span>
<span class="catDesc">T</span>
<span class="venueName">Mill </span>
<span class="eventPrice">3</span>
<span class="chosen"><input type="checkbox" name="event[]" value="11" data-price="35.00"></span>


<section id="Cost">
<h3>Total</h3>
	Total <input type="text" name="total" size="20" readonly="">
</section>

Upvotes: 0

Views: 146

Answers (1)

mplungjan
mplungjan

Reputation: 178350

You have no total in the code you provided.

I would personally use ID when only having one element and if more, use relative addressing and/or delegation

const form = document.getElementById('booking');
const total = document.getElementById('total');
document.getElementById("booking").addEventListener("click", function(e) {
  if (e.target.name === "event[]") {
    let totalprice = 0;
    [...document.querySelectorAll('input[data-price][type=checkbox]')].forEach(function(box) {
      if (box.checked) {
        totalprice += +box.dataset.price;
      } //if
    })
    document.querySelector("[name=total]").value = totalprice.toFixed(2);
  }
})
<form id="booking" method="get">
  <section id="book">
    <h2>Select Events</h2>

    <div class="item">
      <span class="eventTitle">Carmen </span>
      <span class="eventStartDate">2020</span>
      <span class="eventEndDate">2020</span>
      <span class="catDesc">T</span>
      <span class="venueName">Mill </span>
      <span class="eventPrice">3</span>
      <span class="chosen"><input name="event[]" type="checkbox" value="11" data-price="35.00"></span>
    </div>
    <div class="item">
      <span class="eventTitle">Ash</span>
      <span class="eventStartDate">202</span>
      <span class="eventEnd">2020-12-31</span>
      <span class="catD">Exhib</span>
      <span class="venueNa">The Biy</span>
      <span class="eventPr">0.00</span>
      <span class="chosen"><input type="checkbox" name="event[]" value="17" data-price="10.00"></span>
    </div>
  </section>

  <section id="Cost">
    <h3>Total</h3>
    Total <input type="text" name="total" size="20" readonly="">
  </section>
</form>

Upvotes: 1

Related Questions