How to show the filenames under the selected folder on the Radio Button

Question

I'd like to to show the filenames under the folders selected on the Radio Button. However, my program shows only the filenames under the last folder. Even when the selection is changed, the filenames don't change.

I've tried some LINQ statements, but none of them worked. How can I fix this? Here's my entire code:
EDIT: Made the code shorter and added Show_Button_Click()

MainWindow.xaml.cs

using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.ComponentModel;
using System.IO;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Text;
using System.Windows;
using System.Windows.Controls;

namespace Folder_Reader
{
    public class Question
    {
        public string QuestType { get; set; }
        public string Label { get; set; }
        public ObservableCollection Answers { get; set; }
    }

    public class Answer : INotifyPropertyChanged
    {
        public event PropertyChangedEventHandler PropertyChanged;
        private void RaisePropertyChanged([CallerMemberName]string propertyName = null)
            => PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));

        private string _Ans;
        public string Ans
        {
            get => _Ans;
            set
            {
                if (_Ans == value)
                    return;
                _Ans = value;
                RaisePropertyChanged();
                RaisePropertyChanged(nameof(FullName));
            }
        }
        public string FullName => $"{Ans}";
        public bool IsSelected { get; set; }
    }

    public partial class MainWindow : Window
    {
        public ObservableCollection Questions { get; set; }

        List ToBeMergedList = new List();

        public static readonly DependencyProperty QuestionProperty =
            DependencyProperty.Register("Question", typeof(Question), typeof(MainWindow),
                new FrameworkPropertyMetadata((Question)null));

        public Question Question
        {
            get { return (Question)GetValue(QuestionProperty); }
            set { SetValue(QuestionProperty, value); }
        }

        public MainWindow()
        {
            InitializeComponent();
            RunMerge();
        }

        private void RunMerge()
        {
            string dataPath = @"C:\Data\";
            DirectoryInfo[] folders = GetFoldernames(dataPath);

            FillInClass();

            string typePath = null;
            StringBuilder sb = new StringBuilder();

            foreach (var (q, toBeSelectedFolder) in from q in Questions
                                                    from toBeSelectedFolder in folders
                                                    select (q, toBeSelectedFolder))
            {
                sb.AppendLine($"{ toBeSelectedFolder }");
                q.Answers.Add(new Answer() { Ans = toBeSelectedFolder.ToString() });

                // This line finally puts the LAST folder into typePath, but I don't know how to fix this
                typePath = toBeSelectedFolder.FullName.ToString();
                //typePath = q.Answers.Where(a => a.IsSelected).Select(a => a.Ans).ToString();
            }

            DataContext = this;

            string searchPattern = "*log*.xlsx";
            FileInfo[] files = GetFilenames(typePath, searchPattern);

            List DatalogList = new List();
            AddDatalogList(DatalogList, files);
            MyListView.ItemsSource = DatalogList;
        }

        private void FillInClass()
        {
            Questions = new ObservableCollection()
            {
                new Question()
                {
                    QuestType = "Radio",
                    Label = "Type",
                    Answers = new ObservableCollection()
                }
            };
        }

        private static DirectoryInfo[] GetFoldernames(string path)
        {
            DirectoryInfo di = new DirectoryInfo(path);
            DirectoryInfo[] folders =
                di.GetDirectories("*", SearchOption.TopDirectoryOnly);
            return folders;
        }

        private static FileInfo[] GetFilenames(string path, string searchPattern)
        {
            DirectoryInfo di = new DirectoryInfo(path);
            FileInfo[] files =
                di.GetFiles(searchPattern, SearchOption.AllDirectories);
            return files;
        }

        private static void AddDatalogList(List DatalogList, FileInfo[] files)
        {
            var duplicateGroups = files.GroupBy(file => file.Name)
                                       .Where(group => group.Count() > 1);

            foreach (var group in duplicateGroups)
            {
                DatalogList.Add(new Datalog() { Merge = false, Filename = group.First().FullName });
            }

            var singleGroups = files.GroupBy(file => file.Name)
                               .Where(group => group.Count() == 1);

            foreach (var group in singleGroups)
            {
                foreach (var file in group)
                {
                    DatalogList.Add(new Datalog() { Merge = false, Filename = file.FullName });
                }
            }
        }

        private void CheckBox_Checked(object sender, RoutedEventArgs args)
        {
            ToBeMergedList.Add((sender as CheckBox).Content.ToString());
        }

        private void CheckBox_Unchecked(object sender, RoutedEventArgs args)
        {
            ToBeMergedList.Remove((sender as CheckBox).Content.ToString());
        }

        private void Show_Button_Click(object sender, RoutedEventArgs e)
        {
            foreach (Question q in Questions)
            {
                Console.WriteLine(q.Label + " : "
                    + string.Join(", ", q.Answers.Where(a => a.IsSelected).Select(a => a.Ans)));
                MessageBox.Show(q.Label + " : "
                    + string.Join(", ", q.Answers.Where(a => a.IsSelected).Select(a => a.Ans)));
            }
        }

        private void Merge_Button_Click(object sender, RoutedEventArgs e)
        {
            StringBuilder sb = new StringBuilder();

            foreach (var toBeMergedFile in ToBeMergedList)
            {
                sb.AppendLine($"{ toBeMergedFile }");
            }
            MessageBox.Show(sb.ToString());
        }
    }
}

MainWindow.xaml

Datalog.cs

namespace Folder_Reader
{
    public class Datalog
    {
        public bool Merge { get; set; }

        public string Filename { get; set; }
    }
}

Let's assume that there are three folders:

FolderA contains 1_log.xlsx, 2_log.xlsx, 3_log.xlsx
FolderB contains 4_log.xlsx, 5_log.xlsx, 6_log.xlsx
FolderC contains 7_log.xlsx, 8_log.xlsx, 9_log.xlsx.

In this case, 7_, 8_, 9_log.xlsx will be shown, even when FolderA is selected. I expect to see 1_, 2_, 3_log.xlsx when I select FolderA on the Radio Button.

pete the pagan-gerbil · Accepted Answer

The line:

FileInfo[] files = GetFilenames(typePath, searchPattern);

is using the typePath from the last iteration of the loop, which only has files 7, 8 & 9 in it. The list isn't databound and isn't refreshed based on the selection so it'll never show anything different.

Add the files to the answer object (new property), and bind the file list to the selected item. It would mean generating the Datalog objects for all files and adding them to the Answer object, as that Answer is being added to the list (q.Answers.Add(...)). Then instead of adding only the few files to the ListView control (which only happens once), you would bind it's ItemSource property to the selected answers 'Files' property.

EDIT

I've had to make quite a few changes to the original code to make this work. It's not perfect by any means, but hopefully it indicates the right direction to go in for you.

First of all, your file lists aren't connected to Answers in any way. I've added a property of List called Files to the Answer class to hold those, and populated it from the RunMerge method.
The ListView needs to be bound to whatever the selected answer is. This is fairly easy, it's a small tweak to the XAML:

The RunMerge method needs to be reordered slightly to populate the Files property in the Answers, as they are constructed. I've also populated a TopLevel property in the Answer with the main view model class, as we'll need a reference to that later. Some of the other methods now need to return where they didn't before (like AddDatalogList and FillInClass), but there's nothing complicated about that - I leave it to you.

private void RunMerge()
{
    string dataPath = @"C:\Data\";
    DirectoryInfo[] folders = GetFoldernames(dataPath);

    var order = FillInClass();

    string typePath = null;
    StringBuilder sb = new StringBuilder();
    string searchPattern = "*log*.xlsx";
    var viewModel = new MainWindowViewModel
    {
        Order = order
    };

    foreach (var (q, toBeSelectedFolder) in from q in order.Questions
                                            from toBeSelectedFolder in folders
                                            select (q, toBeSelectedFolder))
    {
        sb.AppendLine($"{ toBeSelectedFolder }");
        typePath = toBeSelectedFolder.FullName.ToString();
        q.Answers.Add(new Answer()
        {
            TopLevel = viewModel,
            Ans = toBeSelectedFolder.ToString(),
            Files = AddDatalogList(new List(), GetFilenames(typePath, searchPattern))
        });
    }

    DataContext = viewModel;
}

Binding to the MainWindow as your DataContext makes things messy. I bound it instead to a MainWindowViewModel class that exposes two properties, Order and SelectedAnswer. It looks like this:

public class MainWindowViewModel : INotifyPropertyChanged
{
    public event PropertyChangedEventHandler PropertyChanged;
    private void RaisePropertyChanged([CallerMemberName]string propertyName = null)
    => PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));

    internal void SelectedAnswerChanged()
    {
        RaisePropertyChanged(nameof(SelectedAnswer));
    }

    public Order Order { get; set; }

    public Answer SelectedAnswer
    {
        get { return Order.Questions.First().Answers.FirstOrDefault(x => x.IsSelected); }
    }
}

The SelectedAnswerChanged method in there is quite important. When a user clicks on the radio button, the TwoWay binding that you had there changes the underlying data model (Answer class). However, the SelectedAnswer property doesn't know to trigger a PropertyChanged event based on that so the ItemsSource of your ListView won't change. So in the setter of the IsSelected property in the Answer class, we can call the SelectedAnswerChanged method to trigger the PropertyChanged event from the correct place, which in turn triggers the binding in the ListView to pick up a new ItemsSource... now it is updating the ListView as the user makes a selection. The updated Answer class looks like this:

public class Answer : INotifyPropertyChanged
{
    public event PropertyChangedEventHandler PropertyChanged;
    private void RaisePropertyChanged([CallerMemberName]string propertyName = null)
        => PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));

    private string _Ans;
    public string Ans
    {
        get => _Ans;
        set
        {
            if (_Ans == value)
                return;
            _Ans = value;
            RaisePropertyChanged();
            RaisePropertyChanged(nameof(FullName));
        }
    }
    public string FullName => $"{Ans}";
    private bool _isSelected;
    public bool IsSelected 
    { 
        get
        {
            return _isSelected;
        }
        set
        {
            _isSelected = value;
            RaisePropertyChanged(nameof(IsSelected));
            TopLevel.SelectedAnswerChanged();
        }
    }
    public List Files { get; set; }
    public MainWindowViewModel TopLevel { get; internal set; }
}

Hopefully you can follow what's going on here (and that I didn't miss any pieces out). Separating your models from your window would make it simpler to read and modify and I'd recommend reading up on the MVVM pattern. There are more changes that I could/would make if this were my project, but I wanted to keep the minimum work to help illustrate what needs to be added to make it work.

Hope this helps :)

How to show the filenames under the selected folder on the Radio Button

Answers (1)

Related Questions