Emm
Emm

Reputation: 2507

User information not being saved

I created a field in my signup form asking users for a link to their linkedin profile.

I created a page that returns a list of all the users (mentor users) and noticed that I cannot access the linkedin link. I am not sure if its because I have not saved the link or I am not accessing it correctly.

This is what I have in models.py

class User(AbstractUser):
    is_student = models.BooleanField(default=False)
    is_teacher = models.BooleanField(default=False)
...
class Mentor(models.Model):
    user = models.OneToOneField(User,on_delete=models.CASCADE,primary_key=True)
    linkedin = models.URLField(max_length=200,null=True,blank=True)

    def __str__(self):
        return "Profile of user {}".format(self.user.username)

@receiver(post_save,sender=User)
def create_or_update(sender, instance, created, **kwargs):
    if created:
        post_save.connect(create_or_update, sender=User)

forms.py

class TeacherSignUpForm(UserCreationForm):
    email = forms.EmailField(max_length=100)
    first_name = forms.CharField(max_length=100)
    last_name = forms.CharField(max_length=100)
    linkedin = forms.URLField(max_length=200)

    class Meta(UserCreationForm.Meta):
        model = User
        fields = ('email', 'username', 'first_name', 'last_name')

    def save(self, commit=True):
        self.instance.is_teacher = True
        user = super(UserCreationForm, self).save(commit=False)
        user.email = self.cleaned_data['email']
        user.first_name = self.cleaned_data['first_name']
        user.last_name = self.cleaned_data['last_name']
        user.save()
        mentor = Mentor.objects.get_or_create(
            user=user,
            linkedin=self.cleaned_data['linkedin']
        )
        return user

#basic form
class UserForm(forms.ModelForm):
    class Meta:
        model = User
        fields = ('first_name', 'last_name', 'email')

views.py (teachers.py)

class TeacherSignUpView(CreateView):
    model = User
    form_class = TeacherSignUpForm
    template_name = 'registration/signup_form.html'

    def get_context_data(self, **kwargs):
        kwargs['user_type'] = 'teacher'
        return super().get_context_data(**kwargs)

    def form_valid(self, form):
        user = form.save()
        login(self.request, user)
        return redirect('teachers:app-instructor-dashboard')

students.py (views)

#get list of mentors
def mentor_list(request):
    mentors = User.objects.filter(is_teacher=True).select_related('mentor')
    template_name = 'classroom/students/mentor_list.html'
    context = {'mentors': mentors}
    return render(request, template_name, context)

the html where I generate the list of mentors:

                  <ul id="menu-header-menu">
                      {% for user in mentors %}
                          <li><a href="{{ user.mentor.linkedin }}">{{ user.first_name }} {{ user.last_name }}</a></li>
                      {% endfor %}
                  </ul>

From this list I only get the user's first and last name but cannot get their linkedin profile

Upvotes: 1

Views: 74

Answers (1)

sandeep
sandeep

Reputation: 711

You have use mentor in this line mentors = User.objects.filter(is_teacher=True).select_related('mentor') but not defined mentor anywhere.

Table are connected with this line:

user = models.OneToOneField(User,on_delete=models.CASCADE,primary_key=True)

add related_name .

user = models.OneToOneField(User,on_delete=models.CASCADE,primary_key=True, related_name='mentor')

Then makemigrations and migrate(I Hope you are familiar). Everything else is fine.

Also, print this to verify.

def mentor_list(request):
    mentors = User.objects.filter(is_teacher=True).select_related('mentor')
    # Edited, remember this is just for checking. this is not required
    for user in mentors:
        try:
            print(user.mentor.linkedin)
        except:
             pass
    template_name = 'classroom/students/mentor_list.html'
    context = {'mentors': mentors}
    return render(request, template_name, context)

Upvotes: 1

Related Questions