CODEWITHSUNDEEP
javascriptnode.jsasynchronous
Vipin Dubey
Vipin Dubey

Reputation: 592

Async await not working properly in function call with callbacks

I am new to node.js.I am using await/async to avoid function to run before completing previous one.First of all here is code.

---------------first-----------
exports.createProfileUser = async (req, res, next) => {
    const {user_image,image_two,
    image_three,image_four,
    image_five} = req.files
try{

      var filetype = req.files.user_image.name.split(".");
      var newFileName =  "./public/images/"+Date.now() 
      +  Math.floor(100000 + Math.random() * 900000)
      + "."+filetype[1]

      await insertImages(req,newFileName)
      await createProfile(req,res,newFileName.substring(1), (result) =>{
        if(result){
          return res.json(result)
        }
        else{
            return res.json({
                status:false,
                message:'Error Occurred '
            })
        }  
      })
      . then((result) => {
        if(result){
            return res.json(result)
        }
        else{
            return res.json({
                status:false,
                message:'Error Occurred '
            })
          }
        })
}
catch(error){
    res.sendStatus(500) && next(error)
}};

In above code i want insertImages function to be fully finished before calling createProfile.But that's not happening.Here is insertImages code.

--------------two--------------
insertImages =  (req,baseFileName) =>{

      const {user_id} = req.fields
      var newFileNameTemp =  baseFileName.substr(1);

      if(image){
          let fileType = req.files.image_five.name.split(".")
          let name =  "./public/images/"+Date.now() + "." + fileType[1]
          let tempName = name.substr(1);

          fs.copyFile(req.files.image_five.path, 
            name, 
            async(err) => {
            if (err) {
                console.log("Error in copying file",err)
                return res.json({
                    status:false,
                    message:"Error occurred while updating Profile Pic Two of the user ",

            })
        }

          await makeGallery(user_id,tempName, (resultId)=>{
            console.log('resultId,',resultId)

        })
      });
}

}

After copying file i am saving a object in gallery schema and after that get its _id and update that to users schema.Code for that is.

--------------threee----------------
makeGallery =  async (user_id,imageName,callback) => {
  var g = new Gallery();

  g.image = imageName
  var saved = await g.save()
  .then( async (gallery) => {

      await Users.findOneAndUpdate({user_id: user_id},{$push: {gallery:[gallery._id]}}, 
          {  upsert: true }
          )
          .then(async(data) =>{
              await console.log("Successfully added");    
           })
           await callback(gallery._id)

     })
     .catch(err => {
         return {
             status:false,
             message:err.message,
         }
     });

}

I have used await so function will wait till data updates. But that's not working what i expected.createProfile function is called before insertImages is finished.What i am doing wrong here?Please correct my code i am stuck in this issue.Thanks in advance.

Upvotes: 0

Views: 48

Answers (1)

grodzi
grodzi

Reputation: 5703

Mainly you are not synchronizing with fs.copyFile which is asynchronous

>>> insertImages = async (req,baseFileName) => {
  const {user_id} = req.fields
  var newFileNameTemp =  baseFileName.substr(1);
  if(image){
    let fileType = req.files.image_five.name.split(".")
    let name =  "./public/images/"+Date.now() + "." + fileType[1]
    let tempName = name.substr(1);
>>> await new Promise(function(resolve, reject){
>>>   return fs.copyFile(req.files.image_five.path, name, err => {
        if (err) {
          console.log("Error in copying file",err)
          // you should return the response server elsewhere. NOT in insertImages..
          // you should throw a proper error as well
>>>       return reject(res.json({
            status:false, // should be 500 for internal server error
            message:"Error occurred while updating Profile Pic Two of the user ",
          }))
        }
>>>     return resolve()
      })
    })
  }

  await makeGallery(user_id,tempName, (resultId)=>{
    console.log('resultId,',resultId)
  })
}

Eventually, you may use 

const copyFile = require('util').promisify(fs.copyFile)

so you can directly write 

>>> insertImages = async (req,baseFileName) => {
  const {user_id} = req.fields
  var newFileNameTemp =  baseFileName.substr(1);
  if(image){
    let fileType = req.files.image_five.name.split(".")
    let name =  "./public/images/"+Date.now() + "." + fileType[1]
    let tempName = name.substr(1);
>>> await copyFile(req.files.image_five.path, name).catch(err => {
      console.log("Error in copying file",err)
>>>   throw res.json({ 
        status:false,
        message:"Error occurred while updating Profile Pic Two of the user ",
      })
    })
  }

  await makeGallery(user_id,tempName, (resultId)=>{
    console.log('resultId,',resultId)
  })
}

Upvotes: 1

Related Questions