CODEWITHSUNDEEP
node.jsexpress
mafortis
mafortis

Reputation: 7128

How to get data in express js

For the first time ever i am trying to understand expressJs and I have testing route which returns simple test sentence as JSON, but i can't get in in expressJs.

test.js

var express = require('express');
var router = express.Router();

/* GET home page. */
router.get('https://mysite.ccc/api/test', function(req, res, next) {
  res.json(data)
});

module.exports = router;

apps.js

var createError = require('http-errors');
var express = require('express');
var path = require('path');
var cookieParser = require('cookie-parser');
var logger = require('morgan');

var indexRouter = require('./routes/index');
var testRouter = require('./routes/test'); ////////////////////////////////////////////////////////here

var app = express();

// view engine setup
app.set('views', path.join(__dirname, 'views'));
app.set('view engine', 'jade');

app.use(logger('dev'));
app.use(express.json());
app.use(express.urlencoded({ extended: false }));
app.use(cookieParser());
app.use(express.static(path.join(__dirname, 'public')));

app.use('/', indexRouter);
app.use('/test', testRouter); ////////////////////////////////////////////////////////here

// catch 404 and forward to error handler
app.use(function(req, res, next) {
  next(createError(404));
});

// error handler
app.use(function(err, req, res, next) {
  // set locals, only providing error in development
  res.locals.message = err.message;
  res.locals.error = req.app.get('env') === 'development' ? err : {};

  // render the error page
  res.status(err.status || 500);
  res.render('error');
});

module.exports = app;

I'm not sure but i guess it suppose to show my api sentence in http://127.0.0.1:3000/test instead with:

this command: set DEBUG=myapp:* & npm start it says: 404 not found

and with this command npm start it says request is not defined

what did i do wrong?

Upvotes: 0

Views: 84

Answers (2)

Titus Sutio Fanpula
Titus Sutio Fanpula

Reputation: 3613

👨‍🏫 You can change your test.js with this code below: 👇

var express = require('express');
var router = express.Router();
var axios = require('axios');

/* GET home page. */
router.get('/', async function(req, res, next) {
  try {
    const response = await axios.get('https://mysite.ccc/api/test');
    console.log(response.data);
    res.json(response.data)
  }catch(ex) {
    console.log(ex)
    res.status(400).send(ex.message);
  }
});

module.exports = router;

I hope it's can help 🙏.

Upvotes: 1

Rashad Ibrahimov
Rashad Ibrahimov

Reputation: 3309

Your test.js file should look like this

var express = require('express');
var router = express.Router();

/* GET home page. */
router.get('/', function(req, res, next) {
  // I don't see where you defined data, should be smth like: const data = {};
  res.json(data);
});

module.exports = router;

Here you define your route, so when you start your app you are able to access the route http://127.0.0.1:3000/test.

You probably want to retrieve data from external website? For this you can use any http package, for example axios.

Your final test.js file will look like:

var express = require('express');
var router = express.Router();
var axios = require('axios');

/* GET home page. */
router.get('/', async function(req, res, next) {
  const response = await axios.get('https://mysite.ccc/api/test');
  res.json(response.data);
});

module.exports = router;

Note: I hope you somewhere call app.listen(3000) to start your web server.

Upvotes: 1

Related Questions