CODEWITHSUNDEEP
c#linq
rnn
rnn

Reputation: 2563

How to join two different databases' tables in C# with Linq?

I try to join two different databases tables in c# but it gives me an error how can I handle that ?

this is my query:

 var list = (from h in db.database1.AsEnumerable()
                        join j in NV_DB.database2.AsEnumerable()
                        on h.Creation_Date equals j.Creation_Date
                        where j.Ship_Status == 3 && h.CustomerNo == CustomerNo
                        select new
                        {
                            shipName = h.ShipName,
                            creationDate = j.Creation_Date,
                            endingDate = j.Ending_Date
                        }
                        ).ToList();

if I do like this it gives me System.OverflowException error. But when I run this in sql, it gives me just 30 records*

Upvotes: 1

Views: 1250

Answers (2)

Harald Coppoolse
Harald Coppoolse

Reputation: 30512

To debug this, start dividing your statements into smaller steps:

var list1 = db.database1.AsEnumerable().ToList();
var list2 = NV_DB.database2.AsEnumerable().ToList();

var joinResult = list1.Join(list2,        // join list1 and list2
    list1Row => list1Row.CreationDate,    // from every row in list1 take the CreationDate
    list2Row => list2Row.CreationDate,    // from every row in list2 take the CreationDate

    (list1Row, list2Row) => new           // when they match, make one new object
    {
        // You only need the following properties:
        ShipName = list1Item.ShipName,
        CreationDate = list2Item.CreationDate,
        EndingDate = list2Item.EndingDate,

        ShipStatus = list2Item.ShipStatus,
        CustomerNo = list1Item.CustomerNo,
    })
    .ToList();

var whereResult = joinResult
    .Where(joinedRow => joinedRow.ShipStatus == 3
                     && joinedRow.CustomerNo == customerNo)
    .ToList();

var selectResult = whereResult.Select(whereResultRow => new
{
    ShipName = whereResultRow.ShipName,
    CreationDate = whereResultRow.CreationDate,
    EndingDate = whereResultRow.Ending_Date,
})
.ToList();

This is executed completely as enumerable (in your local process, not by the database management system). My guess would be that this runs smoothly.

Now combine thw first few statements:

var joinResult = db.database1.AsEnumerable()
    .Join(NV_DB.database2.AsEnumerable(),    // join list1 and list2
    list1Row => list1Row.CreationDate,       // from every row in list1 take the CreationDate
    list2Row => list2Row.CreationDate,       // from every row in list2 take the CreationDate

    (list1Row, list2Row) => new              // when they match, make one new object
    {
        // You only need the following properties:
        ShipName = list1Item.ShipName,
        CreationDate = list2Item.CreationDate,
        EndingDate = list2Item.EndingDate,

        ShipStatus = list2Item.ShipStatus,
        CustomerNo = list1Item.CustomerNo,
    })
    .ToList();

When this works, add the Where:

var whereResult = db.database1.AsEnumerable()
    .Join(NV_DB.database2.AsEnumerable(), ...)
    .Where(joinedRow => joinedRow.ShipStatus == 3
                     && joinedRow.CustomerNo == customerNo)
    .ToList();

Etc.

Using your debugger, you'll find the problem within a few minutes (depending on your compilation time). My guess is that it is within your join.

Upvotes: 0

Athanasios Kataras
Athanasios Kataras

Reputation: 26460

You need to remove °AsEnumerable`. While it does not run the sql, when you use it in the where it actually brings the entire tables in memory and then performs the job where part of your query

Your answer is basically the first comment in the accepted answer here: Am I misunderstanding LINQ to SQL .AsEnumerable()?

While AsEnumerable doesn't evaluate the query at the time that it's called , it definitely has an effect. Anything further called on the query will be evaluated using LINQ to objects, so you can't compose additional elements onto the query (another Where or an OrderBy or anything of that nature) that will become part of the SQL statement.

In depth explanation here: https://www.codeproject.com/Articles/732425/IEnumerable-Vs-IQueryable

While querying data from database, IEnumerable executes select query on server side, load data in-memory on client side and then filter data. Hence does more work and becomes slow.

While querying data from database, IQueryable executes select query on server side with all filters. Hence does less work and becomes fas

Upvotes: 2

Related Questions