CODEWITHSUNDEEP
javalistgenericscollectionsequals
Natalie_94
Natalie_94

Reputation: 79

IndexOf method Java

My method indexOf is supposed to return the index of the first occurrence of the specified element in a list, or -1 if this list does not contain the element. More formally: returns the lowest index i such that (E == null ? get(i) == null : E.equals(get(i))), or -1 if there is no such index. The problem with this code is that it always seems to return -1, any suggestions on how I can fix this?

 public int indexOf(E element) {

    Node current = head;
    int index = 0;
    for (int i = 0; i < size; i++) {
        if (current.getmElement() == element) {
            return index;
        }
        index++;
        current = current.getmNextNode();
    }
    return -1;
}

I am using generics to find the next element in the list:

public class Node<E> {
private E mElement;
private Node<E> mNextNode;

Node(E data) {

    this.setmElement(data);
}
public E getmElement() {
    return this.mElement;
}
public void setmElement(E element) {
    this.mElement = element;
}
public Node<E> getmNextNode()
{
    return this.mNextNode;
}
public void setmNextNode(Node<E> node)
{
    this.mNextNode = node;
}}

Upvotes: 0

Views: 82

Answers (1)

Andronicus
Andronicus

Reputation: 26056

You're doing a refernece check: current.getmElement() == element. What you meant to do is to check if those objects are equal:

current.getmElement().equals(element)

Upvotes: 3

Related Questions