Jekson
Jekson

Reputation: 3262

Error: expected pk value, received list for foreignkey field

I cannot save multiple values for the Foreignkey field when adding instances to the database. I don't understand exactly what the problem is: in my code or in the format of the JSON object being passed.

models.py

class VendorContacts(models.Model):
    contact_id = models.AutoField(primary_key=True)
    vendor = models.OneToOneField('Vendors', on_delete=models.CASCADE)
    contact_name = models.CharField(max_length=45, blank=True)
    phone = models.CharField(max_length=45, blank=True)
    email = models.CharField(max_length=80, blank=True, unique=True)

    class Meta:
        db_table = 'vendor_contacts'


class VendorModuleNames(models.Model):
    vendor = models.OneToOneField('Vendors', on_delete=models.CASCADE, primary_key=True)
    module = models.ForeignKey(Modules, models.DO_NOTHING)
    timestamp = models.DateTimeField(auto_now=True)

    class Meta:
        db_table = 'vendor_module_names'
        unique_together = (('vendor', 'module'),)


class Vendors(models.Model):
    COUNTRY_CHOICES = tuple(COUNTRIES)

    vendorid = models.AutoField(primary_key=True)
    vendor_name = models.CharField(max_length=45, unique=True)
    country = models.CharField(max_length=45, choices=COUNTRY_CHOICES)
    nda = models.DateField(blank=True, null=True)
    user_id = models.ForeignKey('c_users.CustomUser', on_delete=models.PROTECT)
    timestamp = models.DateTimeField(auto_now_add=True)

    class Meta:
        db_table = 'vendors'
        unique_together = (('vendorid', 'timestamp'),)

serializers.py

class VendorsSerializer(serializers.ModelSerializer):

    class Meta:
        model = Vendors
        fields = ('vendor_name',
                  'country',
                  'nda',
                  'parent_vendor',)


class VendorContactSerializer(serializers.ModelSerializer):
    class Meta:
        model = VendorContacts
        fields = (
                  'contact_name',
                  'phone',
                  'email',)


class VendorModulSerializer(serializers.ModelSerializer):

    class Meta:
        model = VendorModuleNames
        fields = ('module',)

views.py

class VendorsCreateView(APIView):
    """Create new vendor instances from form"""
    serializer_class = (VendorsSerializer)

    def post(self, request, *args, **kwargs):
        vendor_serializer = VendorsSerializer(data=request.data)
        vendor_contact_serializer = VendorContactSerializer(data=request.data)
        vendor_modules_serializer = VendorModulSerializer(data=request.data)
        try:
            vendor_serializer.is_valid(raise_exception=True) \
                and vendor_contact_serializer.is_valid(raise_exception=True) \
                and vendor_modules_serializer.is_valid(raise_exception=True) \
            vendor = vendor_serializer.save(user_id=request.user)
            vendor_contact_serializer.save(vendor=vendor)
            vendor_modules_serializer.save(module= maybe something here?????, vendor=vendor)

        except ValidationError:
            return Response({"errors": (vendor_serializer.errors,
                                        vendor_contact_serializer.errors,
                                        vendor_modules_serializer.errors
                                        )},
                            status=status.HTTP_400_BAD_REQUEST)
        else:
            return Response(request.data, status=status.HTTP_200_OK)

JSON body

{
        "vendor_name": "Awrazofgsxsdsxjwszsslsasdjegdzasas",
        "country": "Canada",
        "module": [
            1,
            2
        ],
        "NDA date": "",
        "contact_name": "Tim",
        "email": "[email protected]",
        "phone": "+3464784594940",
        "parent_vendor": "23"
    }

When I send JSON, I get the response

{
    "module": [
        "Incorrect type. Expected pk value, received list."
    ]
}

Looks like I'm finally confused about multiple saving

Upvotes: 1

Views: 213

Answers (1)

oz19
oz19

Reputation: 1876

Your ForeignKey should be set on the related class Modules.

Upvotes: 1

Related Questions