CODEWITHSUNDEEP
angularjasminekarma-jasminekarma-runnerangular-test
Francesco Borzi
Francesco Borzi

Reputation: 61854

How to make ng test to fail on warnings

I've just finished fixing several warnings on my unit/component tests of my Angular app, that run using ng test (with Karma/Jasmine).

This process can be quite time-consuming as it is not always obvious to spot which test case(s) is actually causing the warning(s).

So now that I don't have any more warnings, I'm wondering if there is a way to make ng test to automatically fail whenever there are any warnings.

Upvotes: 13

Views: 4249

Answers (5)

Kelly
Kelly

Reputation: 91

Where in the file? just at the bottom after karma.start()?

Upvotes: 0

krema
krema

Reputation: 1219

In test.ts I monkey patched it like so to print also the stack trace in case of an error:

console.error = function (message?: any, ...optionalParams: any[]): void {
  const messages = [message, ...optionalParams];
  const output = messages?.map(x => x.hasOwnProperty('stack') ? x.stack : x);
  fail(`Test contained console error:\n\n${output.join('\n')}`);
};

console.warn = function (message?: any, ...optionalParams: any[]): void {
  console.error(message, ...optionalParams);
};

Upvotes: 0

bohoffi
bohoffi

Reputation: 21

Define an extra file in your workspace root - called karma.globals.js for example which looks like:

// add globals for karma test runs
console.warn = (message) => { throw new Error(message); };

Now include it in your root karma.conf.js like:

const { join } = require('path');

module.exports = () => {
  return {
    
    // ...

    files: [
      join(__dirname, 'karma.globals.js')
    ]

    // ...
  };
};

Upvotes: 2

Darlan Alves
Darlan Alves

Reputation: 500

A simple and easy fix is a beforeAll block in your test.ts file. It replaces all console methods with an error function.

That way the tests will fail if you call console.log and you will know which ones.

If you still wanna use console.log within a unit being tested, then you could spy on it. But that's also bad due to shared global state.

Here's an example:

const errorFn = () => { throw new Error('No console logs!'); };
beforeAll(() => Object.keys(console).forEach((fn: string) => (console as any)[fn] = errorFn));

Upvotes: 1

AliF50
AliF50

Reputation: 18839

Maybe something like this in test.ts or someplace where the tests get initialized.

console.warn = (message) => throw new Error(message);

I don't know if I would recommend this because warnings are just that warnings, but errors are errors and should be dealt with immediately. Where you would place this for just the tests can be tricky too.

Upvotes: 5

Related Questions