My RecyclerView is not showing any data - Firebase

Question

I'm following a tutorial on youtube and trying to display firebase data as recycler view. However, it is completely blank in my layout. I cannot understand why. I've gone through similar questions here and tried all the solutions but none work. Please help me figure this out.Thanks.

Following is my firebase db.

Home2.java

package com.example.oddsynew;

import android.os.Bundle;
import android.widget.Toast;

import androidx.annotation.NonNull;
import androidx.appcompat.app.AppCompatActivity;
import androidx.recyclerview.widget.LinearLayoutManager;
import androidx.recyclerview.widget.RecyclerView;

import com.google.firebase.database.DataSnapshot;
import com.google.firebase.database.DatabaseError;
import com.google.firebase.database.DatabaseReference;
import com.google.firebase.database.FirebaseDatabase;
import com.google.firebase.database.ValueEventListener;

import java.util.ArrayList;

public class Home2 extends AppCompatActivity {

    DatabaseReference myRef;
    RecyclerView newJobList;
    ArrayList list;
    HomeAdapter adapter;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_home2);

        newJobList = (RecyclerView) findViewById(R.id.newJobs);
        newJobList.setLayoutManager(new LinearLayoutManager(this));
        list = new ArrayList();

        adapter = new HomeAdapter(Home2.this, list);
        newJobList.setAdapter(adapter);

        myRef = FirebaseDatabase.getInstance().getReference().child("Job");
        myRef.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(@NonNull DataSnapshot dataSnapshot) {
                for (DataSnapshot ds: dataSnapshot.getChildren()){
                    Job j = ds.getValue(Job.class);
                    list.add(j);
                }
            }

            @Override
            public void onCancelled(@NonNull DatabaseError databaseError) {
                Toast.makeText(Home2.this, "Error", Toast.LENGTH_SHORT).show();
            }
        });
    }
}

This is my layout.

This is the model class.

        


    

package com.example.oddsynew;

public class Job {
    private String job_name;
    private String recruiter_name;
    private String location;
    private String job_charge;

    public Job() {
    }

    public Job(String job_name, String recruiter_name, String location, String job_charge) {
        this.job_name = job_name;
        this.recruiter_name = recruiter_name;
        this.location = location;
        this.job_charge = job_charge;
    }

    public String getJob_name() {
        return job_name;
    }

    public void setJob_name(String job_name) {
        this.job_name = job_name;
    }

    public String getRecruiter_name() {
        return recruiter_name;
    }

    public void setRecruiter_name(String recruiter_name) {
        this.recruiter_name = recruiter_name;
    }

    public String getLocation() {
        return location;
    }

    public void setLocation(String location) {
        this.location = location;
    }

    public String getJob_charge() {
        return job_charge;
    }

    public void setJob_charge(String job_charge) {
        this.job_charge = job_charge;
    }
}

And my Home Adapter class.

package com.example.oddsynew;

import android.content.Context;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ImageView;
import android.widget.TextView;

import androidx.annotation.NonNull;
import androidx.recyclerview.widget.RecyclerView;

import java.util.ArrayList;

public class HomeAdapter extends RecyclerView.Adapter {

    Context context;
    ArrayList jobs;

    public HomeAdapter(Context c, ArrayList j){
        context = c;
        jobs = j;
    }

    @NonNull
    @Override
    public MyViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
        return new MyViewHolder(LayoutInflater.from(context).inflate(R.layout.job_row, parent, false));
    }

    @Override
    public void onBindViewHolder(@NonNull MyViewHolder holder, int position) {
        holder.recruiterName.setText(jobs.get(position).getRecruiter_name());
        holder.jobName.setText(jobs.get(position).getJob_name());
        holder.jobLocation.setText(jobs.get(position).getLocation());
        holder.jobCharge.setText(jobs.get(position).getJob_charge());
    }

    @Override
    public int getItemCount() {
        return jobs.size();
    }

    class MyViewHolder extends RecyclerView.ViewHolder {
        TextView recruiterName, jobName, jobLocation, jobCharge;
        ImageView profPic;

        public MyViewHolder(@NonNull View itemView) {
            super(itemView);
            recruiterName = itemView.findViewById(R.id.recruiterName);
            jobName = itemView.findViewById(R.id.jobName);
            jobLocation = itemView.findViewById(R.id.jobLocation);
            jobCharge = itemView.findViewById(R.id.jobCharge);
            profPic = itemView.findViewById(R.id.prof_pic);
        }
    }
}

Pavneet_Singh · Accepted Answer

You need to call adapter.notifyDataSetChanged() after the for loop to inform the adapter to reprocess the data after updates in the data source(list) as

for (DataSnapshot ds: dataSnapshot.getChildren()){
    Job j = ds.getValue(Job.class);
    list.add(j);
}
adapter.notifyDataSetChanged();
// ^^^^^^^^^^^^^^^^^^^^^^^

To get the children, use Jobs instead of Job as

myRef = FirebaseDatabase.getInstance().getReference().child("Jobs");
//                                                           ^^^^

My RecyclerView is not showing any data - Firebase

Answers (2)

Related Questions