CODEWITHSUNDEEP
c#.netfile.net-core
Dmytro
Dmytro

Reputation: 17196

How to properly delete a file in .Net Core with C# from a folder with large amount of other files or folders

I am removing files in a loop with File.Delete(String) in a simplest .Net Core Console application:

1. foreach (var listing in listings)
2.    File.Delete(listing.Path);

BUT the issue is that the application randomly hangs on line 2, no exception is thrown. After application restart, several files are removed successfully and the app randomly hangs, again, on another file.

There are some items to note:

I suspect that issue is somehow related to the amount of files. But File.Delete should be the most reliable way to remove a file, and it just hangs without any response for multiple hours. Which forces me to kill the process of the app. Is there a better or more efficient way to remove a file?

Update: After moving all the files to another Windows machine in a network with an SSD installed and executing the application there it worked perfectly fine. So it may look like a hardware issue. Therefore I will rephrase the question title from How to properly delete a file in .Net Core with C# to How to properly delete a file in .Net Core with C# from a folder with large amount of other files or folders

Upvotes: 3

Views: 1875

Answers (1)

JohnT
JohnT

Reputation: 51

1) Don't expect to create an array with hundreds of thousands of filenames and then loop through them deleting them very fast

2) The file system, especially if the directory is on a network share, mapped drive, or in use by another application will be slow and block operations. For example, a processing adding new files to a directory as fast as possible will conflict and possibly deadlock with one deleting files as fast as possible from the same directory.

3) Files may be locked by another process

Try some tests a) How long does it take to get a list of all of the files to be deleted? b) How long does it take to delete 1000 files in a row?

One queue system I developed had large numbers of files with multiple processes creating files, multiple processes processing files and then deleting the files.

We had 3 directories: Inbound, BeingProcessed, and ForDeletion

Each new file was put in the Inbound directory Another process would move the file from the inbound directory to the BeingProcessed directory, open and lock the file, then process the file and the move the file to the ForDeletion directory Another process would delete files in the ForDeletion directory

Upvotes: 0

Related Questions