CODEWITHSUNDEEP
c#winapiapicompare
Krähne
Krähne

Reputation: 185

Which of the following codes would be more practical, feasible, and fast? C#

Both of these methods work correctly, but I was wondering which of them is "better"? Either best practices, less bug prone or faster?

Method 1:

    public static ListViewItem[] GetProcessData()
    {
        ManagementClass MgmtClass = new ManagementClass("Win32_Process");
        ListViewItem[] ProcessItems = new ListViewItem[MgmtClass.GetInstances().Count - 2];
        int i = 0;

        foreach (ManagementObject Processes in MgmtClass.GetInstances())
        {
            if (!Processes["Name"].ToString().ToLower().Contains("system"))
            {
                string[] ProcessInfo = { Processes["Name"].ToString(), Processes["ProcessId"].ToString() };
                ProcessItems[i] = new ListViewItem(ProcessInfo);
                i++;
            }
        }

        return ProcessItems;
    }

Method 2:

    public static ListViewItem[] GetProcessData()
    {
        Process[] PInfo = Process.GetProcesses();
        ListViewItem[] ProcessItems = new ListViewItem[PInfo.Length - 2];
        int j = 0;

        for (int i = 0; i < PInfo.Length; i++)
        {
            if (!PInfo[i].ProcessName.ToLower().Contains("system") & !PInfo[i].ProcessName.ToLower().Contains("idle"))
            {
                string[] ProcessInfo = { PInfo[i].MainModule.ModuleName, PInfo[i].Id.ToString() };
                ProcessItems[j] = new ListViewItem(ProcessInfo);
                j++;
            }
        }

        return ProcessItems;
    }

Upvotes: 0

Views: 104

Answers (1)

Alex Aza
Alex Aza

Reputation: 78447

I would use Process class as a typed approach. A little less bug prone in this case:

public static ListViewItem[] GetProcessData()
{
    return Process.GetProcesses()
        .Where(arg => arg.Id != 0 && !arg.ProcessName.ToLower().Contains("system"))
        .Select(arg => new ListViewItem(new[] { arg.MainModule.ModuleName, arg.Id.ToString() }))
        .ToArray();
}

Upvotes: 2

Related Questions