CODEWITHSUNDEEP
c#multithreadingtaskthreadpooldeadlock
gladtomeetyou
gladtomeetyou

Reputation: 13

Why ThreadPool decides to use the exact context thread which called Task.Wait?

Why ThreadPool decides to use the exact context thread which called Task.Wait?

There is the question. For some reasons I do not see a comment button neither for the question nor for any of its answers. So, I am asking a related question in a separate thread.

In the linked question there is an answer which points to the blog. According to this blog the following statement holds.

There is the code piece:

// My "library" method.
public static async Task<JObject> GetJsonAsync(Uri uri)
{
  // (real-world code shouldn't use HttpClient in a using block; this is just example code)
  using (var client = new HttpClient())
  {
    var jsonString = await client.GetStringAsync(uri);
    return JObject.Parse(jsonString);
  }
}

// My "top-level" method.
public void Button1_Click(...)
{
  var jsonTask = GetJsonAsync(...);
  textBox1.Text = jsonTask.Result;
}

And there is the deadlock occurrence explanation:

  1. The top-level method calls GetJsonAsync (within the UI/ASP.NET context).
  2. GetJsonAsync starts the REST request by calling HttpClient.GetStringAsync (still within the context).
  3. GetStringAsync returns an uncompleted Task, indicating the REST request is not complete.
  4. GetJsonAsync awaits the Task returned by GetStringAsync. The context is captured and will be used to continue running the GetJsonAsync method later. GetJsonAsync returns an uncompleted Task, indicating that the GetJsonAsync method is not complete.
  5. The top-level method synchronously blocks on the Task returned by GetJsonAsync. This blocks the context thread.
  6. … Eventually, the REST request will complete. This completes the Task that was returned by GetStringAsync.
  7. The continuation for GetJsonAsync is now ready to run, and it waits for the context to be available so it can execute in the context.
  8. Deadlock. The top-level method is blocking the context thread, waiting for GetJsonAsync to complete, and GetJsonAsync is waiting for the context to be free so it can complete.

And my question is particularly about the step 7. Why does the ThreadPool decides to take a blocked thread and wait while it will unblock to ask that thread to run the code? Why not just take any other thread?

Upvotes: 0

Views: 74

Answers (1)

weichch
weichch

Reputation: 10045

GetJsonAsync is not executed on an arbitrary thread pool thread. It is executed on the context thread.

As per the example code, the task GetJsonAsync was created by a button click event, which is executed on UI thread (context thread). When the task is being waited, current context (in this case the UI synchronization context) is captured. After the task is completed, the continuation is resumed on the same context.

In step 7, the task attempts to return to the UI thread, but the UI thread is blocked by .Result, waiting the task to return. So the deadlock happens.

I noticed that the referenced question was asking about ASP.NET WebApi applications. So just want to clarify some points:

ASP.Net WebAPI does have a special synchronization context, but it is different from the UI context. There's only one UI thread, so the context schedules callbacks / continuations to only the UI thread.

However, the synchronization context for ASP.Net WebAPI does not capture one single thread. ASP.Net code can run on different / arbitrary thread. The context is in charge of restoring thread data and making sure the continuations are chained together on a first come first served basis.

Upvotes: 1

Related Questions