CODEWITHSUNDEEP
c++arraysloopsreturn
Yashasav Prajapati
Yashasav Prajapati

Reputation: 25

Array doesn't print anything on executing code

I was creating a function that takes an integer number, finds the next multiple of 5 after the number and then if the difference between the multiple and the number is less than 3, then it prints out the multiple else the number itself, finally prints out an array of all the numbers.

 #include <bits/stdc++.h>
 #include <iostream>

 using namespace std;


vector<int> gradingStudents(vector<int> grades) {
int size=grades.size();
int c=0;
int d;
vector<int> array;
for(int i=0;i<size;i++){

    while(grades[i]>(c*5)){
    c++;
    }
    d=c*5;

    if((d-grades[i])<3){
        array[i]=d;
    }else{
        array[i]=grades[i];
    }
    d=0;
    c=0;
}    
return array ;

Now I tried running this function, and the compiler gives shows no error in the program in the code, however the code doesn't print anything.

Someone Please help.

Upvotes: 1

Views: 89

Answers (3)

Umar Farooq
Umar Farooq

Reputation: 416

i feel nothing is wrong with your function but calling of this function is a bit tricky let me give you a quick main to try may be that will help you.

int main() {

    vector <int> test ;
    test.push_back(1);
    test.push_back(2);
    gradingStudents(test);
    return 0;
}

Try initially the size of the vector is empty i hope you are sending something from the main . Your code is very inefficient whenever you find time must read how to write an efficient code.

Upvotes: 1

john
john

Reputation: 87959

Proably your code is crashing, which is why it doesn't print anything. And one reason it might be crashing is your vector use is wrong.

It's very common to see beginners write code like this

vector<int> array;
for (int i=0;i<size;i++) {
    array[i] = ...;

But your vector has zero size. So array[i] is an error, always.

Two possible solutions

1) Make the vector the correct size to begin with

vector<int> array(size);
for (int i=0;i<size;i++) {
    array[i] = ...;

2) Use push_back to add items to the vector, every time you call push_back the vector increases in size by one.

vector<int> array(size);
for (int i=0;i<size;i++) {
    array.push_back(...);

And please don't call your vector array, that's just taking the piss.

Upvotes: 1

Michael
Michael

Reputation: 950

First, I have to say that this code is extremely inefficient. Finding the difference between the closest muliplication of 5 and a number can be simply done by:

int difference = (n - (n + 4) / 5 * 5) - n;

Explanation: C++ is rounding down the division, so (n + 4) / 5 is n / 5 rounded up, and hence (n+4)/5*5 is the closest multiplication of 5.

Another thing, you declare an array but never resize it, so its size is 0. You need to resize it either by specifying the size in the constructor or using the std::vector::resize method.

code:

std::vector<int> gradingStudents(std::vector<int> grades) {
    std::size_t size = grades.size();
    std::vector<int> array(size);
    for (int i = 0; i < size; i++) {

        int closestMul = (grades[i] + 4) / 5 * 5;

        if (closestMul - grades[i] < 3) {
            array[i] = closestMul;
        }
        else {
            array[i] = grades[i];
        }
    }
    return array;
}

Upvotes: 2

Related Questions