Rez
Rez

Reputation: 196

How can I query over a manyTOmany model field correctly?

Alright so here's what I am trying to do, as a developer noobie. I am attempting to create an inbox for a user. I have a Conversation model that has a many to many field and then I have an InstantMessanger model the has sender_id, date, and a receiver_id field that is a foreign key to Conversation. What I am attempting to do is iterate over Conversation first and display the members whom the user has had convo's with and then display a link to where it takes you to the actual contents of that message. However, I'm stuck at getting the members to even display. I've tried a number of things here and looked around, but I keep getting errors such as 'conversation' model is not iterable or displaying but displaying as 'dating_app.Profile.none`, the object, and so forth. So I'm pretty stuck here and not sure how to do this. What's the right way to do this?

views.py

def messages(request,profile_id):

    messages = InstantMessage.objects.filter(Q(sender_id=request.user)).\
    values('sender_id','receiver_id', 'message', 'date', ).\
    order_by('date',)


    profile = get_object_or_404(Profile,id=profile_id)

    conversations = Conversation.objects.filter(members=request.user)


return render(request, 'dating_app/messages.html', {'messages': messages,'profile': profile,'conversations':conversations,})

messages.html

{% for conversation in conversations %}
    <li class="text-right list-group-item">
        {% for members in conversation %}{% if members != request.user %}
            {{ members.username }}<br/>
        {% endif %}{% endfor %}

    </li>
{%endfor %}

models.py

class ProfileManager(BaseUserManager):



    def create_user(self, username, email,description,photo, password=None):
        if not email:
            raise ValueError("You must creat an email")
        if not username:
            raise ValueError("You must create a username!")
        if not description:
            raise ValueError("You must write a description")
        if not photo:
            raise ValueError("You must upload a photo")

        user = self.model(
                email=self.normalize_email(email),
                username = username, 
                description= description,
                photo= photo,

            )

        user.set_password(password)
        user.save(using=self._db)
        return user 


    def create_superuser(self, username, email,description,photo, password):
        user = self.create_user(
                email=self.normalize_email(email),
                password=password,
                username=username,
                description=description,
                photo=photo,

            )

        user.is_admin=True
        user.is_staff=True
        user.is_superuser=True
        user.save(using=self._db)
        return user




class Profile(AbstractBaseUser):

    class Meta:
        swappable = 'AUTH_USER_MODEL'


    email                       = models.EmailField(verbose_name="email")
    username                    = models.CharField(max_length=30, unique=True)
    date_joined                 = models.DateTimeField(verbose_name='date joined', auto_now_add=True)
    last_login                  = models.DateTimeField(verbose_name='last login', auto_now=True)
    is_admin                    = models.BooleanField(default=False)
    is_active                   = models.BooleanField(default=True)
    is_staff                    = models.BooleanField(default=False)
    is_superuser                = models.BooleanField(default=False)
    #what I added
    description                 = models.TextField()
    photo                       = models.ImageField(upload_to='profile_photo',blank=False, height_field=None, width_field=None, max_length=100)
    matches                     = models.ManyToManyField(settings.AUTH_USER_MODEL, related_name='+', blank=True)



    USERNAME_FIELD = 'username'
    REQUIRED_FIELDS = ['description','photo','email']


    objects = ProfileManager()


    def __str__(self):
        return self.username


    def has_perm(self, perm, obj=None):
        return self.is_admin


    def has_module_perms(self,app_label):
        return True



class UserVote(models.Model):

    user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.CASCADE)
    voter = models.ForeignKey(settings.AUTH_USER_MODEL, related_name='given_vote', on_delete=models.CASCADE)
    vote = models.BooleanField(default=False)

    class Meta:
        unique_together = (('user', 'voter'))


class Conversation(models.Model):
    members = models.ManyToManyField(settings.AUTH_USER_MODEL)




class InstantMessage(models.Model):

    sender = models.ForeignKey(settings.AUTH_USER_MODEL, related_name= 'senderr',on_delete=models.CASCADE )
    receiver = models.ForeignKey(Conversation, on_delete=models.CASCADE)
    message = models.TextField()
    date = models.DateTimeField(auto_now_add=True)


    def __unicode__(self):
        return self.message

Upvotes: 1

Views: 42

Answers (1)

willeM_ Van Onsem
willeM_ Van Onsem

Reputation: 476544

You can display the members with:

{% for conversation in conversations %}
    <li class="text-right list-group-item">

    {% for member in conversation.members.all %}
        {% if member != request.user %}
            {{ member.username }}<br/>
        {% endif %}
    {% endfor %}
    <li>
{% endfor %}

This will however result in an N+1 problem where in order to show the members, you will make an extra query per conversation, which is not very efficient. You can boost efficiencly with .prefetch_related(..) [Django-doc]:

def messages(request,profile_id):
    messages = InstantMessage.objects.filter(Q(sender_id=request.user)).\
    values('sender_id','receiver_id', 'message', 'date', ).\
    order_by('date',)
    profile = get_object_or_404(Profile,id=profile_id)

    conversations = Conversation.objects.filter(
        members=request.user
    ).prefetch_related('members')

    return render(request, 'dating_app/messages.html', {'messages': messages,'profile': profile,'conversations':conversations,})

EDIT: you can order the messages by last received message (in descending order) with:

from django.db.models import Max

def messages(request,profile_id):
    messages = InstantMessage.objects.filter(Q(sender_id=request.user)).\
    values('sender_id','receiver_id', 'message', 'date', ).\
    order_by('date',)
    profile = get_object_or_404(Profile,id=profile_id)

    conversations = Conversation.objects.filter(
        members=request.user
    ).annotate(
        last_message=Max('instantmessage__date')
    ).prefetch_related('members').order_by(
        '-last_message'
    )

    return render(request, 'dating_app/messages.html', {'messages': messages,'profile': profile,'conversations':conversations,})

Upvotes: 1

Related Questions