CODEWITHSUNDEEP
node.jsmongodbmongoosemongodb-query
Thi Pham
Thi Pham

Reputation: 23

Mongoose - replace all array elements

I want to replace all array's elements in 'prices' filed as below:

{
 "name": "My customer name"
 "taxCode":123456
 "prices": 
         [
           {
             "name": "Chocolate",
             "unitPrice": 10
           },
           {
             "name": "Cookie",
             "unitPrice": 9
           }
         ]
}

The JSON that uses to change 'prices' is:

{
 "prices": 
          [
             {
              "name": "Chocolate1", 
              "unitPrice": 10
             },
             {
              "name": "Candy",
              "unitPrice": 5
             }
           ]
}

And here is my code to replace the 'prices' array

router.route('/:obj/:id')
  .put((req, res) => {
    const PObj  = require('../models/customer');
    PObj.findById(req.params.id, (err, doc) => {
      if (err) { 
        console.log('Lookup error: ' + err);
        res.status(500).send('Error');
      } else if (doc) {
        doc.update({$set: req.body}, (err, task) => {
          res.status(200).json(task);
        });     } else {
        res.status(404).send('Something is wrong');
      }
    });
  });

After code executed is done but without any changes in Mongo DB. Please help me to correct my code. Thank!

Upvotes: 2

Views: 424

Answers (1)

whoami - fakeFaceTrueSoul
whoami - fakeFaceTrueSoul

Reputation: 17935

If your req.body prints that prices array then it has to be req.body.prices, also rather than fetching the document & updating it - Which is a two- way process, You can try this :

router.route("/:obj/:id").put((req, res) => {
  const PObj = require("../models/customer");
  PObj.findByIdAndUpdate(
    req.params.id, /** this 'req.params.id' has to be `_id` value of doc in string format */
    /** internally mongoose will send this as { $set: { prices: req.body.prices }} which will replace `prices` array will new array,
     *  Just in case if you wanted to push new values, have to manually do { $push: { prices: req.body.prices }} each object */
    { prices: req.body.prices },
    { new: true }, /** returns updated doc, this option is not needed if you don't need doc - by default it returns old doc */
    (err, doc) => {
      if (err) {
        console.log("Lookup error: " + err);
        res.status(500).send("Error");
      } else if (doc) { 
        res.status(200).json(task);
      } else { /** `doc` value will be null if no doc is not found for given id */
        res.status(404).send("Something is wrong");
      }
    }
  );
});

Ref : .findByIdAndUpdate()

Upvotes: 1

Related Questions