Reputation: 143
i'm developing a free drawing canvas. it has two tool. a brush for drawing and an eraser. by default the brush is selected and user can draw. by selecting eraser from drop down menu, I change "globalcompositeoperation" to "destination-out"; and user can erase. so far everything good. but when user changes the tool back to brush mode, the (ctx.globalcompositeoperation = "source-over") does not take effect and eraser remains active for ever! How can I switch between brush and eraser properly. thanks
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
Tool:
<select id="tool">
<option value="brush">Brush</option>
<option value="eraser">Eraser</option>
</select>
<canvas id="canvas"></canvas>
<script>
window.addEventListener("load", () => {
const canvas = document.getElementById("canvas");
const ctx = canvas.getContext("2d");
canvas.height = window.innerHeight - 8;
canvas.width = window.innerWidth - 8;
ctx.strokeStyle = "black";
ctx.lineWidth = 10;
ctx.shadowBlur = 10;
ctx.shadowColor = "rgb(0, 0, 0)";
ctx.lineJoin = "round";
ctx.lineCap = "round";
let painting = false;
function startPosition(e) {
painting = true;
draw(e);
}
function finishedPosition() {
painting = false;
ctx.beginPath();
}
function draw(e) {
if (!painting) return;
ctx.lineTo(e.clientX, e.clientY);
ctx.stroke();
}
canvas.addEventListener("mousedown", startPosition);
canvas.addEventListener("mouseup", finishedPosition);
canvas.addEventListener("mousemove", draw);
var select = document.getElementById("tool");
select.addEventListener("change", function () {
mode = select.value;
if (mode == "brush") {
// this can't bring brush back!
ctx.globalcompositeoperation = "source-over";
console.log("brush");
} else {
// this changes brush to eraser successfully
ctx.globalCompositeOperation = "destination-out";
ctx.globalcompositeoperation = "source-over";
console.log("eraser");
}
});
});
</script>
</body>
</html>
Upvotes: 1
Views: 635
Reputation: 17594
Looks like you have a typo globalCompositeOperation
.
Remember JavaScript is a case-sensitive language.
here is your code working:
const canvas = document.getElementById("canvas");
const ctx = canvas.getContext("2d");
canvas.height = window.innerHeight - 8;
canvas.width = window.innerWidth - 8;
ctx.strokeStyle = "black";
ctx.lineWidth = ctx.shadowBlur = 10;
ctx.shadowColor = "rgb(0, 0, 0)";
ctx.lineJoin = ctx.lineCap = "round";
let painting = false;
function startPosition(e) {
painting = true;
draw(e);
}
function finishedPosition() {
painting = false;
ctx.beginPath();
}
function draw(e) {
if (!painting) return;
ctx.lineTo(e.clientX, e.clientY);
ctx.stroke();
}
canvas.addEventListener("mousedown", startPosition);
canvas.addEventListener("mouseup", finishedPosition);
canvas.addEventListener("mousemove", draw);
var select = document.getElementById("tool");
select.addEventListener("change", function() {
mode = select.value;
if (mode == "brush") {
ctx.globalCompositeOperation = "source-over";
} else {
ctx.globalCompositeOperation = "destination-out";
}
});
<!DOCTYPE html>
<html lang="en">
<body>
Tool:
<select id="tool">
<option value="brush">Brush</option>
<option value="eraser">Eraser</option>
</select>
<canvas id="canvas"></canvas>
</body>
</html>
Upvotes: 2
Reputation: 143
if statement was in wrong place!
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<style>
*{
margin: 0;
padding: 0;
box-sizing: border-box;
}
#c{
border: 2px black solid;
}
</style>
</head>
<body>
Tool:
<select id="tool">
<option value="brush">Brush</option>
<option value="eraser">Eraser</option>
</select>
<canvas id="canvas"></canvas>
<!-- <canvas id="c" width="500" height="300"></canvas> -->
<!-- <script src="./canvas.js"></script> -->
<script>
window.addEventListener("load", () => {
const canvas = document.getElementById("canvas");
const ctx = canvas.getContext("2d");
canvas.height = window.innerHeight - 8;
canvas.width = window.innerWidth - 8;
ctx.strokeStyle = "black";
ctx.lineWidth = 10;
ctx.shadowBlur = 10;
ctx.shadowColor = "rgb(0, 0, 0)";
ctx.lineJoin = "round";
ctx.lineCap = "round";
let painting = false;
let mode = 'brush'
function startPosition(e) {
painting = true;
draw(e);
}
function finishedPosition() {
painting = false;
ctx.beginPath();
}
function draw(e) {
if (!painting) return;
if(mode=='brush') {
ctx.globalCompositeOperation = 'source-over';
ctx.strokeStyle = 'black';
ctx.lineWidth = 3;
} else {
ctx.globalCompositeOperation = 'destination-out';
ctx.lineWidth = 10;
}
ctx.lineTo(e.clientX, e.clientY);
ctx.stroke();
}
canvas.addEventListener("mousedown", startPosition);
canvas.addEventListener("mouseup", finishedPosition);
canvas.addEventListener("mousemove", draw);
var select = document.getElementById("tool");
select.addEventListener("change", function () {
mode = select.value;
});
});
</script>
</body>
</html>
Upvotes: 0