CODEWITHSUNDEEP
node.jsexpressmongoose
Kelp
Kelp

Reputation: 1268

Having problems exporting model functions (Express and Mongoose)

I have been looking at code (https://github.com/cmarin/MongoDB-Node-Express-Blog) to learn NodeJS, Express, Mongoose, and I am having trouble importing a 'Poll' function from my 'models.js' file, particularly the 'save' function.

I am getting the following error:

500 TypeError: Object function (){} has no method 'save'

It occurs on line 54 of my app.js. I am unable to save a new Poll because it cannot find the function: https://github.com/kelper/Poll/blob/master/app.js

Here is my models file, and the save function is on line 62: https://github.com/kelper/Poll/blob/master/models.js

One other quick question. How can I exclude files from being committed? I keep committing swap files and such to my repo.

If you see anything else wrong with my code, please tell me. I know one person mentioned that my naming conventions are confusing. How should I be naming my variables?

Upvotes: 3

Views: 3078

Answers (2)

Josh
Josh

Reputation: 12722

Looks like you've got a proxy object built up using prototype. In this case you're going to have to 'new up' an instance to use it as Raynos mentioned.

I think what you're expecting is what an object literal provides, rather than a prototypical class. Something like:

module.exports.PollModel = {
  findPolls  : function (callback) { ... },
  findById   : function (id, callback) { ... },
  updateById : function (id, body, callback) { ... }
}

I'd personally use the mongoose schema directly.

Mongoose uses the Schema object to do queries for that particular model, but if you actually want to create and save new objects of that schema type, you want to new up a new object.

// Assume you've exposed the mongoose Poll schema directly
var Poll = require('./models').Poll;

// Create a new instance
var instance = new Poll();

// Valid
instance.save();

// Not valid
instance.find(function(err, docs){});

// Valid
Poll.find(function(err, docs){});

// Not valid
Poll.save();

Upvotes: 4

Raynos
Raynos

Reputation: 169531

PollModel is a function constructor, you want to create an object.

var PollModel = require('./models').PollModel; is wrong

var pollModel = new (require('./models').PollModel); is right.

Upvotes: 5

Related Questions