CODEWITHSUNDEEP
javasqljdbc
Mr.Bin
Mr.Bin

Reputation: 3

how to search by id in jdbc

I use in my code jdbc wrote the following code to search id:

public Item findById(String id) {
        Item result = null;

        String s = "SELECT id, key, name, creat, description FROM trackersql WHERE id = :id";

        try (Connection connection = init()) {
            PreparedStatement statement = connection.prepareStatement(s);

            ResultSet resultSet = statement.executeQuery();

            while(resultSet.next()) {
                Item item = new Item();

                statement.setString(1, id);
                statement.setString(2, item.getKey());
                statement.setString(3, item.getName());
                statement.setLong(4, item.getCreat());
                statement.setString(5, item.getDescription());
                statement.executeUpdate();
            }
        } catch (SQLException e) {
            e.printStackTrace();
        }

        return result;
    }

doing my code check this way:

try {
            DriverManager.registerDriver(new org.postgresql.Driver());
        } catch (SQLException e) {
            e.printStackTrace();
        }
        TrackerSQL trackerSQL = new TrackerSQL();
        Item item1 = new Item("1", "1", "test1", 1, "test1");

        trackerSQL.init();

        System.out.println(trackerSQL.findById(item1.getId()));

but I get the following error:

ERROR: syntax error (approximate position: ":") Position: 69 at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2103) at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1836) at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:257) at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:512) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:388) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:273) at ru.job4j.trackersql2.TrackerSQL.findById(TrackerSQL.java:104) at ru.job4j.trackersql2.TrackerSQL.main(TrackerSQL.java:188) null

what is my mistake?

Upvotes: 0

Views: 3506

Answers (1)

Jens
Jens

Reputation: 69460

JDBC does not know named parameter. repalce :id with ?. Also you never bind the parameter 

String s = "SELECT id, key, name, creat, description FROM trackersql WHERE id = ?";
try (Connection connection = init()) {
    PreparedStatement statement = connection.prepareStatement(s);
    statement.setString(1,id)
    ResultSet resultSet = statement.executeQuery();

There is an other erro in your code:

            statement.setString(1, id);
            statement.setString(2, item.getKey());
            statement.setString(3, item.getName());
            statement.setLong(4, item.getCreat());
            statement.setString(5, item.getDescription());
            statement.executeUpdate();

must be

          Item item = new Item();

            item.setId(1, rs.getString(1));
            item.setKey(2, rs.getString(2));
          return item;

Upvotes: 0

Related Questions