CODEWITHSUNDEEP
javascriptarrays
kurtixl
kurtixl

Reputation: 419

Javascript - Removing commas from an array of string numbers

I currently have an array of strings that are numbers 

data.dataArr = [0: " 1,431,417 "
​​
1: " 1,838,127 "
​​
2: " 679,974 "
​​
3: " 2,720,560 "
​​
4: " 544,368 "
​​
5: " 1,540,370 "]

I am attempting to remove the commas so my data returns 0: "1431417" , 1: 1838127 ...

After removing commas I am then mapping this array to convert it to an array of numbers and not strings. But when console.logging the finalArray that should return an array of numbers I am getting NaN I believe this is due to the part of removing the commas.

Here is my code:

let data = {
  dataArr: [
  " 1,431,417 ",
    " 1,838,127 ",
    " 679,974 ",
    " 2,720,560 ",
    " 544,368 ",
    " 1,540,370 "
  ]
};

//removing commas
let arrData = data.dataArr.map(e => e.replace(/(,\s*)+/, ','));
let finalArr = arrData.map(Number);
console.log(finalArr)

alternatively I've tried :

let arrData = data.dataArr.replace(/,/g, "")

Which resulted in "data.dataArr.replace is not a function"

Upvotes: 8

Views: 949

Answers (7)

Vinay Jadhav
Vinay Jadhav

Reputation: 364

      ['1,234', '7,8,90,'].map(eachNo => {
return eachNo.split(',').join('')
});

Split() will split string where it will find ,(comma) and will return an array of strings.
join() will operate on array of strings.

Upvotes: 3

tinymothbrain
tinymothbrain

Reputation: 412

let data = new Object();
data.dataArr = [ " 1,431,417 ",
" 1,838,127 ",
" 679,974 ",
" 2,720,560 ",
" 544,368 ",
" 1,540,370 "];

const finalArr = data.dataArr.map(x => x.replace(/[^0-9]/g, ''));

console.log(finalArr)

Upvotes: 1

Ilijanovic
Ilijanovic

Reputation: 14904

You can .map() over the array and split up by , and then join them at "". You also need to wrap everything in Number to convert it to an number

let dataArr =  [
  " 1,431,417 ",
    " 1,838,127 ",
    " 679,974 ",
    " 2,720,560 ",
    " 544,368 ",
    " 1,540,370 "
  ]
  
  let result = dataArr.map(el => Number(el.split(",").join("")))
  
  console.log(result)

Upvotes: 1

mscdeveloper
mscdeveloper

Reputation: 2889

Maybe like this:

var data = {};

data.dataArr =
  [
    " 1,431,417 ",
    " 1,838,127 ",
    " 679,974 ",
    " 2,720,560 ",
    " 544,368 ",
    " 1,540,370 "
  ];

function array_to_numbers(_arr){
	var out = [];
	for(var key in _arr){
	  var el = 	_arr[key];
	  el = el.trim();
	  el = el.replace(new RegExp(',','g'), '');
	  el = parseInt(el)||0;
	  out.push(el);
	}
	return out;
}
console.log(array_to_numbers(data.dataArr));

Upvotes: 1

brk
brk

Reputation: 50291

You can use number in same map callback function, g to remove all occurrence of ,

dataArr = [" 1,431,417 ", " 1,838,127 ", " 679,974 ", " 2,720,560 ", " 544,368 ", " 1,540,370 "]

let arrData = dataArr.map(e => Number(e.replace(/(,\s*)+/g, '').trim()));
console.log(arrData)

Upvotes: 6

Ashish Ranjan
Ashish Ranjan

Reputation: 12960

There also seems to be a space in your array which would be giving NaN, Remove everything other than digits and maybe a dot.

Try this regex:

e.replace(/[^\d.]/g, '');

Upvotes: 2

Roko C. Buljan
Roko C. Buljan

Reputation: 206048

Use Array.prototype.map()

const data = {};
data.dataArr = [
  "   1,431,417 ",
  " 1,838,127 ",
  " 679,974 ",
  " 2,720,560 ",
  " 544,368 ",
  " 1,540,370 ",
];

const numbersArray = data.dataArr.map(str => Number(str.replace(/\D/g, '')));

console.log(numbersArray)

Upvotes: 1

Related Questions