CODEWITHSUNDEEP
ios
John Doah
John Doah

Reputation: 1999

UIImagePicker init takes too long

I have an imagePicker, and when I initialize it, it takes pretty long time, it gets the screen to lag, for example, I have a screen where a user can write information and chose a picture, when I click on a button to move to that screen, it lags a bit before actually moving to that screen. I ran the Time Profiler, and the problem with the screen seems to be the initialization of the imagePicker.

This is the imagePicker class:

import UIKit

public protocol ImagePickerDelegate: class {
    func didSelect(image: UIImage?)
}

class ImagePicker: NSObject {

    private let pickerController: UIImagePickerController
    private weak var presentationController: UIViewController?
    private weak var delegate: ImagePickerDelegate?

    init(presentationController: UIViewController, delegate: ImagePickerDelegate){
        self.pickerController = UIImagePickerController()

        super.init()

        self.presentationController = presentationController
        self.delegate = delegate

        self.pickerController.delegate = self
        self.pickerController.allowsEditing = true
        self.pickerController.mediaTypes = ["public.image"]
    }

    private func action(for type: UIImagePickerController.SourceType, title: String) -> UIAlertAction?{
        guard UIImagePickerController.isSourceTypeAvailable(type) else { return nil}
        return UIAlertAction(title: title, style: .default, handler: { [unowned self] _ in
            self.pickerController.sourceType = type
            self.presentationController?.present(self.pickerController, animated: true)
        })
    }

    func present(from sourceView: UIView){
        let alertController = UIAlertController(title: nil, message: nil, preferredStyle: .actionSheet)
        if let action = self.action(for: .camera, title: ImagePickerStrings.takePicture){
            alertController.addAction(action)
        }

        if let action = self.action(for: .savedPhotosAlbum, title: ImagePickerStrings.cameraRoll) {
            alertController.addAction(action)
        }

        alertController.addAction(UIAlertAction(title: GeneralStrings.cancel, style: .cancel, handler: nil))

        self.presentationController?.present(alertController, animated: true)
    }

    private func pickerController(_ controller: UIImagePickerController, didSelect image: UIImage?){
        controller.dismiss(animated: true, completion: nil)
        self.delegate?.didSelect(image: image)
    }
}

extension ImagePicker: UIImagePickerControllerDelegate{
    public func imagePickerControllerDidCancel(_ picker: UIImagePickerController) {
        self.pickerController(picker, didSelect: nil)
    }

    public func imagePickerController(_ picker: UIImagePickerController, didFinishPickingMediaWithInfo info: [UIImagePickerController.InfoKey : Any]) {
        guard let image = info[.editedImage] as? UIImage else {
            return self.pickerController(picker, didSelect: nil)
        }
        self.pickerController(picker, didSelect: image)
    }
}

And this is how I initialize it:

I have this variable inside the class:

var imagePicker: ImagePicker!

This is in the viewDidLoad:

override func viewDidLoad() {
    super.viewDidLoad()
    imagePicker = ImagePicker(presentationController: self, delegate: self)
}

Upvotes: 2

Views: 552

Answers (1)

wolfsayswof
wolfsayswof

Reputation: 199

It's usually very slow on simulator and overall in debug mode.

See UIImagePickerController really slow when calling alloc init

Upvotes: 3

Related Questions