CODEWITHSUNDEEP
djangodjango-modelsdjango-rest-frameworkdjango-rest-framework-simplejwt
iscream
iscream

Reputation: 790

Django custom user passwords not being hashed

I created custom user models as so:

class UserAccount(AbstractBaseUser, PermissionsMixin):
    email = models.EmailField(max_length=255, unique=True)
    name = models.CharField(max_length=255)
    is_active = models.BooleanField(default=True)
    is_staff = models.BooleanField(default=False)

    objects = UserAccountManager()

    USERNAME_FIELD = 'email'
    REQUIRED_FIELDS = ['name']

    def get_full_name(self):
        return self.name

    def get_short_name(self):
        return self.name

    def __str__(self):
        return self.email

manager:

class UserAccountManager(BaseUserManager):
    def create_user(self, email, name, password=None):
        if not email:
            raise ValueError('Users must have unique email address')

        email = self.normalize_email(email)
        user = self.model(email=email, name=name)

        user.set_password(password)
        user.save()

        return user

    def create_superuser(self, email, name, password):
        user = self.create_user(email, name, password)

        user.is_superuser = True
        user.is_staff = True
        user.save()

        return user

I have called the user.set_password(password) in the manager, yet it is not hashing it. For this, I can't login! Here is the view that I used for the signup process:

class SignupView(APIView):
    permission_classes = (permissions.AllowAny,)

    def post(self, request, format=None):
        data = self.request.data

        name = data['name']
        email = data['email']
        password = data['password']
        password2 = data['password2']

        if password == password2:
            if User.objects.filter(email=email).exists():
                return Response({'error': 'Email already exists'})
            if len(password) < 6:
                return Response({'error': 'Password must be more than 6 characters in length'})
            user = User.objects.create(email=email, password=password, name=name)
            user.save()
            return Response({'success': 'User created successfully'})
        return Response({'error': 'Passwords do not match'})

I have seen other solutions but they were related to serializers. In my case I have not used any serializer. How do i fix this?

Upvotes: 2

Views: 1147

Answers (1)

willeM_ Van Onsem
willeM_ Van Onsem

Reputation: 476503

You should not call .create(…), but .create_user(…):

class SignupView(APIView):
    permission_classes = (permissions.AllowAny,)

    def post(self, request, format=None):
        data = self.request.data

        name = data['name']
        email = data['email']
        password = data['password']
        password2 = data['password2']

        if password == password2:
            if User.objects.filter(email=email).exists():
                return Response({'error': 'Email already exists'})
            if len(password) < 6:
                return Response({'error': 'Password must be more than 6 characters in length'})
            user = User.objects.create_user(email=email, password=password, name=name)
            user.save()
            return Response({'success': 'User created successfully'})
        return Response({'error': 'Passwords do not match'})

Upvotes: 3

Related Questions